Repository navigation
Fix native review responses, error details, and finding locations - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native reviews can fail or finish prematurely when intermediate commentary is parsed as the final answer. Findings on valid diff-context lines are also discarded, and subscription failures hide their cause.
Review prompt construction and PR-scope instructions match main exactly. This PR contains only the three CLI fixes and their tests; evaluation scripts and results remain on the experimental branch. Review-quality improvement is not established, and this exact prompt-preserving combination has not been benchmarked.
Evidence
After: Those tests pass, including checks for the existing round budget, wrong-side/out-of-hunk locations, and exclusion of arbitrary server messages from errors.
go test -race ./...,go vet ./..., andgo build -trimpath ./cmd/diffvouchpass locally.Merge Danger
Door: two-way
Code rollback requires no configuration or stored-data migration.
Blast Radius: Reviews
Changes native OpenAI response handling, subscription error text, and finding eligibility for local review results and GitHub publication. Commentary-only responses continue within the existing request budget. Findings outside the supplied diff or on an unsupported side remain excluded.