Repository navigation
clarify batch aggregation scrubbing - #4911
Merged
Merged
Conversation
tgeoghegan
added
the
allow-changed-migrations
tgeoghegan
force-pushed
the
timg/clarify-batch-aggregation-scrubbing
branch
3 times, most recently
from
October 19, 2026 18:18
f14dbe9 to
c7ea143
Compare
tgeoghegan
changed the base branch from
main
to
timg/leader-selected-collection-job-idempotency-key-collector-integration-interop
October 19, 2026 18:18
tgeoghegan
added this pull request to stack #4914
October 19, 2026 18:18
tgeoghegan
marked this pull request as ready for review
October 19, 2026 18:18
divergentdave
approved these changes
Oct 19, 2026
jcjones
approved these changes
Oct 19, 2026
| // ReportAggregationStateCode exists alongside the public ReportAggregationState because there is no | ||
| // apparent way to denote a Postgres enum literal without deriving FromSql/ToSql on a Rust enum | ||
| // type, but it is not possible to derive FromSql/ToSql on a non-C-style enum. | ||
| /// ReportAggregationStateCode corresponds to the `batch_aggregation_state` enum. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// ReportAggregationStateCode corresponds to the `batch_aggregation_state` enum. | |
| /// BatchAggregationStateCode corresponds to the `batch_aggregation_state` enum. |
| // type, but it is not possible to derive FromSql/ToSql on a non-C-style enum. | ||
| /// ReportAggregationStateCode corresponds to the `batch_aggregation_state` enum. | ||
| /// | ||
| /// It exists alongside the public ReportAggregationState because there is no apparent way to denote |
Contributor
There was a problem hiding this comment.
Suggested change
| /// It exists alongside the public ReportAggregationState because there is no apparent way to denote | |
| /// It exists alongside the public BatchAggregationState because there is no apparent way to denote |
tgeoghegan
force-pushed
the
timg/clarify-batch-aggregation-scrubbing
branch
2 times, most recently
from
October 20, 2026 14:51
99974f5 to
5d40a92
Compare
Base automatically changed from
timg/leader-selected-collection-job-idempotency-key-collector-integration-interop
to
main
October 20, 2026 15:11
tgeoghegan
force-pushed
the
timg/clarify-batch-aggregation-scrubbing
branch
from
October 20, 2026 15:11
5d40a92 to
672ed30
Compare
Adds some doccomments on items related to scrubbed batch aggregations, as well as tidying up comments in the DB schema so they don't scroll off the right side of one's editor window.
tgeoghegan
force-pushed
the
timg/clarify-batch-aggregation-scrubbing
branch
from
October 20, 2026 15:25
672ed30 to
206e99c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some doccomments on items related to scrubbed batch aggregations, as well as tidying up comments in the DB schema so they don't scroll off the right side of one's editor window.