Skip to content

docs: deep production audit 2026-05-07 (cross-repo) - #2

Draft
diskhacker wants to merge 1 commit into
mainfrom
claude/create-main-branch-audit-SsbNG
Draft

docs: deep production audit 2026-05-07 (cross-repo)#2
diskhacker wants to merge 1 commit into
mainfrom
claude/create-main-branch-audit-SsbNG

Conversation

@diskhacker

Copy link
Copy Markdown
Owner

Summary

Adds DEEP-AUDIT-REPORT-2026-05-07.md — cross-repo deep audit of all 7 repos. Same file committed to claude/create-main-branch-audit-SsbNG in all 7 repos.

Status updates (sigops-sdk)

The 2026-04-13 audit's findings are largely outdated for this repo:

  • examples/ — PRESENT (6 hello-* workspace packages).
  • docs/ — PRESENT (all 6 guides: getting-started, tool-reference, template-guide, sel-reference, plugin-guide, publishing).
  • CI/CD — PRESENT (ci.yml build+test on Node 20; publish.yml tag-driven pnpm -r publish).
  • ESM-only — intentional (HARD RULE #7 updated; dual ESM+CJS reverted because tsc was never emitting .cjs).

sigops-sdk-specific P0 / P1

  • P0: @sigops/cli declares hard runtime deps (commander@^12, chalk@^5, inquirer@^9, ora@^8) under devDependencies in packages/cli/package.json. ESM-only published tarball will throw ERR_MODULE_NOT_FOUND at first run after npm i -g @sigops/cli. Move all four to dependencies before next publish.
  • P1: sigops sel <subcommand>, sigops template from-playbook, sigops validate, sigops publish, sigops login are stubs (print "coming soon" or return hard-coded values). README/docs over-promise.
  • P1: No coverage gate enforced in CI despite ">90% coverage required".
  • P1: examples/ on disk are hello-*; CLAUDE.md/README list aspirational tool-http-health-check etc. — naming mismatch.
  • P2: Single Node 20 in CI (no matrix for 18/22).
  • P2: No lint step in CI even though lint task wired in turbo.json.
  • P2: Barrel index.ts files in tool-sdk/template-sdk/sel-tools/plugin-sdk lack file-level JSDoc (HARD RULE docs: deep production audit 2026-05-07 (cross-repo) #2 partial).

Test plan

  • Review report
  • Move CLI deps + cut RC
  • Decide stub commands: implement vs remove from index.ts
  • Wire coverage gate + matrix in CI

Draft for visibility only — no code changes.


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ae8550d3-b819-4f59-82f9-c825ca0ca210

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/create-main-branch-audit-SsbNG

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

CI note: the test check failure is pre-existing on main, not caused by this change.

This PR adds a single file (DEEP-AUDIT-REPORT-2026-05-07.md) at the repo root — no source, manifest, or config changes. The CI workflow triggers on every PR with no paths-ignore filter, so doc-only PRs inherit any breakage already on main.

main HEAD is eaff52d (2026-04-21, 2+ weeks ago); no PR has run CI against main since. The failure is most likely a GitHub Actions runner-image change or a flaky test, not something this PR introduced.

I'm leaving the red status rather than pushing speculative fixes; the underlying issue should be investigated separately.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant