Repository navigation
Ciphertext downloads buffer unlimited response data before size validation - #35
Closed
dipeshbabu wants to merge 1 commit into
Closed
dipeshbabu wants to merge 1 commit into
dipeshbabu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream replacement: subconscious-systems#34
This PR was created in the fork in error. The fix and its issue are now submitted to upstream.
getBytes buffers the entire response and only pullTarget checks its size afterward. A response exceeding the expected ciphertext size can consume unbounded memory before being rejected.
Enforce the expected size and the protocol cap while streaming, reject oversized Content-Length values before reading, cancel failed downloads, and release reader locks. Tests cover declared oversize, streamed oversize without a length header, exact-limit content, empty bodies, and invalid limits.
Validation: frozen-lockfile dependencies, typecheck, full tests, npm build, bundled CLI smoke checks, and Ubuntu/Windows CI on Node 20/22 before PR creation.
This PR is based on the CI foundation branch; merge that PR first.
Closes #33.
All branch CI checks passed on c78543f: https://github.com/dipeshbabu/vibi-cli/actions/runs/37263748462