Repository navigation
Trace size validation omits the AES-GCM authentication tag - #27
Closed
dipeshbabu wants to merge 1 commit into
Closed
dipeshbabu wants to merge 1 commit into
dipeshbabu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream replacement: subconscious-systems#22
This PR was created in the fork in error. The fix and its issue are now submitted to upstream.
MAX_TRACE_BYTES limits ciphertext, but uploadVersion compares the cap against plaintext. Plaintexts in the last 16 bytes of the allowed range pass local validation and then fail server registration after expensive encryption.
Account for the 16-byte GCM tag before encryption or any network activity. A regression test checks the boundary and proves an oversized trace makes no request.
Validation: frozen-lockfile dependencies, typecheck, full tests, npm bundle build, and bundled CLI version/help smoke tests. The Ubuntu/Windows Node 20/22 branch CI must pass before this PR is created.
This PR is based on the CI foundation branch so its diff contains only this bug fix; merge the CI foundation PR first.
Closes #12.
All branch CI checks passed on 73b0ffa: https://github.com/dipeshbabu/vibi-cli/actions/runs/37263168612