Repository navigation
change-password writes a private key to disk on locked machines - #18
Closed
dipeshbabu wants to merge 1 commit into
Closed
dipeshbabu wants to merge 1 commit into
dipeshbabu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream replacement: subconscious-systems#10
This PR was created in the fork in error. The fix and its issue are now submitted to upstream.
Changing an encryption password uses
local?.privateKey ?? pair.privateKey, so a locked machine or one with no local key silently starts remembering the plaintext private key. A different cached key can also be retained under the new public key.Preserve the locked or remembered state, and retain only the matching verified key. Tests cover no local key, locked, remembered, and mismatched cached keys and verify decryption using the new password.
Validation: frozen-lockfile dependencies, typecheck, full tests, npm bundle build, and bundled CLI version/help smoke tests. The Ubuntu/Windows Node 20/22 branch CI must pass before this PR is created.
This PR is based on the CI foundation branch so its diff contains only this bug fix; merge the CI foundation PR first.
Closes #6.
All branch CI checks passed on cb53fa1: https://github.com/dipeshbabu/vibi-cli/actions/runs/37263012167