fix(ci): match SelfHosted-macOS flag case in codecov carryforward - #3253
Open
mc856 wants to merge 1 commit into
Open
fix(ci): match SelfHosted-macOS flag case in codecov carryforward#3253mc856 wants to merge 1 commit into
mc856 wants to merge 1 commit into
Conversation
mc856
requested review from
Dreamsorcerer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
July 28, 2026 15:28
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
External fork PRs get a spurious
codecov/projectfailure whenever the base commit on main has self-hosted macOS coverage..codecov.ymllists the carryforward flag asSelfHosted-macos, but ci.yml uploadsSelfHosted-${{ matrix.os }}, i.e.SelfHosted-macOS. Codecov flag names are case-sensitive, so the macOS report never carries forward on fork PRs, whileSelfHosted-LinuxandSelfHosted-Large— exact-case names in the same block — carry forward fine. Dates back to the flag split in #1901.Observed on #3210 (docs-only, so the project total couldn't legitimately move): the head report carries forward Linux ×4 and Large ×2 but no macOS; base 68bb0bd has two
SelfHosted-macOSuploads at 74.90%, head lands at 74.62% — the missing 291 of 106,086 tracked lines are exactly the reported −0.28%. Same shape on #3060 (−0.30%, merged over the red X) and #3179 (−1.56%). #3201 and #3181 passed only because their base commits happened to be missing the macOS upload too, so for external contributors the check is effectively a coin flip on the base commit's runner health.Solution
One-character case fix so the config matches the flag CI actually uploads.
How to Test
Codecov reads the YAML from the head commit, so this PR's own report should list
SelfHosted-macOSas carried forward (visible under the uploads on the Codecov page for the head commit), and fork PRs opened after this merges should stop seeing the spurious ~0.3% project drop.AI assistance
Claude Code with Fable 5: ran the codecov API comparison and drafted this description. I verified the flag names in
.codecov.yml/ci.ymland the upload/coverage numbers myself.Checklist