feat(dimsim): add closed-loop agent evaluations - #3249
Open
michaellee8 wants to merge 9 commits into
Open
Conversation
michaellee8
marked this pull request as ready for review
July 28, 2026 13:15
michaellee8
requested review from
Dreamsorcerer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
July 28, 2026 13:15
Author
Screen.Recording.2026-07-28.at.8.47.18.PM.mp4Demo screen recording demostrating navigation from outside the house to the bathtub |
… into michaellee8/feat/dimsim-agent-2
Author
|
Ran all 5 scenarios and passed including one of them doing a fresh longer navigation task from outside the house to the innermost bathtub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Related to #3069.
Problem
DimSim workflows could score browser state, but they could not run a
deterministic closed-loop evaluation against a live DimOS agent. There was no
correlated reset → dispatch → scoring lifecycle, authoritative server-physics
reset, bounded infrastructure failure handling, or task-scoped way to validate
an agent declaration.
This also allowed
find-and-go-to-bathtubto produce false positives: the agentcould claim it found the bathtub without being physically close to it.
Solution
Add an explicit single-workflow agent mode:
dimsim eval apartment/find-and-go-to-bathtub --agentThe implementation:
runEval → evalReady → evalReset → resetAck → agent_send → evalStart → evalResultprotocol correlated by
runId.dispatch.
agent_sendtool.infrastructure errors.
navigation and by clearing bridge velocity.
infrastructure failure.
/agentoutput sidecar for the discovery workflow.find-and-go-to-bathtubto satisfy both:FOUND_BATHTUBsidecar tests.
The branch also improves the live DimSim runtime by:
DimSimConnectionNo shared system prompt is changed. The
FOUND_BATHTUBinstruction belongs onlyto the relevant workflow.
How to Test
Start the live stack:
Then run the evaluation:
deno run -A --unstable-net misc/DimSim/cli/cli.ts \ eval apartment/find-and-go-to-bathtub \ --agent --port 8092Automated validation:
Results:
FOUND_BATHTUBdeclaration capturedAI assistance
OpenAI Codex with GPT-5.6-Sol was used extensively to inspect the codebase, implement
the feature, write tests and documentation, operate the live stack, and analyze
evaluation behavior. I made the technical decisions, reviewed the resulting behavior and live
evaluation outcome.
Checklist
CLA.