Repository navigation
Conversation
… mismatched parameters (e.g. sentance split not working on chinese/korean)
…ug fix for Korean adjectives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Korean (and serendipitously some Chinese!) support to the text processors. Korean attaches particles and endings to words (학교, 학교에서 and 학교가 are apparently all "school"), which broke tokenizing and word matching.
Tokenise
Word matching (Filter by words or phrases, Over-time word counts)
TermMatcherin helpers, which also matches Korean Hangul stored as separate letters.Other
Known limits: the Chinese sentence splitter can split inside links (see the note on
urls_in_text), and Kiwi analyzes text twice when grouping by sentence. URLs in text is FREAKING HARD.New dependency:
kiwipiepy~=0.24.0, so existing installs need a pip install or an image rebuild. Tests are intests/test_korean_text.py, and I checked it in the UI on the BEEP! Korean news comments dataset (hate speech dataset I found online).