Skip to content

History graph: clicking a reinforcement layout loads nothing #37

Closed

Description

@fstwn

What happens

On the component page, clicking a reinforcement layout event in the History card's swimlane graph appears to do nothing: no layout is shown, nothing visible loads.

What the code does today

onEvent in src/frontend/components/components/history/SwimlaneGraph.tsx treats every evidence record the same way:

  • a record of another piece: router.push('/components/<lane>#record-<id>');
  • a record of this piece: scroll to the card #record-<id> (EvidenceCard) and ring it for 1.8 s, or a toast "That record is not on this version of the page." when the card is not in the DOM.

So the click never opens the viewer, and for a layout the scroll target is the evidence list card, not the bars. Possible reasons it looks like nothing happens (not yet reproduced):

  • the card is not rendered: a superseded (corrected) record sits behind "Show corrected records" in ComponentRecordsCard.tsx, so only the toast appears;
  • the card is rendered but the scroll is small or the ring is missed;
  • the event is an evidence group, which only expands in the graph;
  • on another lane the hash navigation lands before the records have loaded, so the browser finds no #record-....

Expected

A click on a reinforcement_layout event opens the layout in the viewer, as the card's "Show in viewer" does since 0.6.4.1 (decision 8.178): /components/<lane>?snapshot=<position.snapshot_id>&layout=<evidence id>#component-viewer, for every status the caller may see. If the record has no drawable bars or no position, fall back to the card scroll. Other evidence methods keep the card scroll.

Also: when the target card is behind "Show corrected records", open that section before scrolling instead of only showing the toast; on another lane, scroll once the records have loaded.

Done when

  • Clicking a layout event shows its bars in the viewer, on this piece and on a parent or child lane.
  • Clicking any other record still scrolls to its card, also a corrected one.
  • Unit tests for the target chosen per event; a live check on the local stack with a piece that has a published and a draft layout.

Activity

  1. added
    bugSomething isn't working
    frontendIssues regarding the NextJS Frontend
    on Oct 28, 2026
  2. fstwn commented on Oct 29, 2026

    @fstwn
    ContributorAuthor

    Fixed in 0.6.4.2 (#43).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfrontendIssues regarding the NextJS Frontend

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions