Repository navigation
Conversation
…w engine The snapshot records the current, broken output. The new engine does not split the view, so every row is drawn on one page over the header.
Yoga lays out in float32. Past 2^15 pt a position is only exact to about 1/256 pt, so rounding alone can make touching siblings overlap by more than the fixed 0.001 pt tolerance. The column was then treated as wrapped and became one unsplittable leaf. Scale the tolerance with the position.
🦋 Changeset detectedLatest commit: 9233272 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@exoego is attempting to deploy a commit to the diegomura Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
experimentalPagination, aViewstops splitting once its content goes past 2^15 pt (32,768 pt, about 44 A4 pages). All remaining children are drawn on one page, on top of each other. The legacy engine is fine. I hit this in a real app, where a 50-page report came out as 2 pages.isWrappedintoItems.tstreats a column whose siblings overlap by more than 0.001 pt as a wrapped one, and keeps it whole. Yoga lays out in float32, so past 2^15 pt a position is only exact to 1/256 pt. Rounding alone makes touching siblings overlap by about 0.0015 pt. Example: a child at 32,928.015625 with height 47.064 ends at 32,975.0796, but the next child starts at 32,975.078125.The tolerance now grows with the position (twice the float32 step, at least 0.001 pt). A real wrapped column jumps back by hundreds of points, so it is still detected.
The first commit adds a snapshot test that records the broken output (every row on one page). The second commit fixes it, and the snapshot changes to the split pages.