Repository navigation
Conversation
|
@exoego is attempting to deploy a commit to the diegomura Team on Vercel. A member of the Team first needs to authorize it. |
|
Contributor
Author
|
@diegomura Please take a look this first. It fixes CI failure. |
Load pdf.js's bundled standard fonts in the snapshot helper. Without them pdf.js draws unembedded Helvetica with the system font, which differs between macOS and Linux. Revert the raised threshold and update the snapshots whose text glyphs changed.
exoego
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI fails on master and on every PR. Two float snapshot tests are 5.39% different on Linux, just over the 5% threshold.
Cause
The snapshot helper does not pass
standardFontDataUrlto pdf.js. So pdf.js draws unembedded Helvetica with the system font, and that font differs between macOS and Linux.Fix
Pass pdf.js's bundled
standard_fontsinrenderComponent.js. Now macOS (arm64) and Linux (amd64) render all 96 snapshots the same. The threshold stays at 5%.I updated the 13 snapshots whose only change is the text glyphs.
Tests
packages/renderertests pass on macOS and in anode:22linux/amd64 container.