Repository navigation
ci: build on Node 26 - #27
Merged
Merged
Conversation
The CI, the release and the website deploys ran on Node 24, while Vercel's previews (and its default) use Node 26, as does local development. Production deploys build with `vercel build` on the runner, so they were recorded with Node 24 instead of the project's 26.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the CI, the release and the website deploys from Node 24 to Node 26.
Why
Production deploys don't build on Vercel:
website.ymlrunsvercel buildon the GitHub runner, thenvercel deploy --prebuilt. That runner used Node 24, from.github/actions/setup, so production was recorded with 24 while Vercel's default (and the previews it builds itself) is 26.Vercel attributes the version to
package.json. The rootengines.nodeis the range>=22.x, which accepts 24.With this change, the CI, the release, production deploys, previews and local development all run on Node 26. Vite 8 (
^20.19.0 || >=22.12.0) and Qwik rc.4 (^20.3.0 || >=21.0.0) both support it.What changes
.github/actions/setup/action.yml: Node 26. It's used by the CI, the release's stage job and the website deploy.release.yml: thegithub_releasejob (changelogithub) also uses 26.The root
engines.nodestays>=22.x. It's the published library'spackage.json, so pinning it to26.xwould force Node 26 on anyone who installs qwik-sonner.The CI of this PR runs on Node 26 and checks the change.