Repository navigation
docs: prepare the docs and the release steps for 2.0.0-beta.2 - #22
Merged
Merged
Conversation
The beta.1 known issues are gone: a Toaster or useSonner() first rendered on the client subscribes (and unsubscribes on unmount), topLayer works with several Toasters and comes back above modals, the theme listener follows the prop, and the type unions are exported. Also: classes.default only applies to toasts without a type, toast.getHistory() keeps up to 100 toasts, important and Action.actionButtonStyle are marked deprecated, and the behaviour now matches sonner 2.0.8. The one issue left is the dev-server stall with two toasts back to back.
The dialog demo no longer closes the top-layer popover before opening the modal, the counter demo loses its reload hint, and the site imports Position and Theme from qwik-sonner instead of deriving them.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the docs in line with what 2.0.0-beta.2 ships (#16) and switches the release docs to
pnpm stage.Merge this right before
pnpm release. It toucheswebsite/, so merging deploys the site, and the docs would describe beta.2 while beta.1 is still the published version.Docs (
website/)Known issues: the beta.1 entries are gone, now that they're fixed:
useSonner()first rendered on the client;topLayerwith modals or several Toasters;theme="system"listener;The one issue left is documented: on the dev server only, two toasts fired back to back can stall the Toaster.
Introduction: removed the "keep the Toaster in a server-rendered layout" warning.
Advanced:
useSonner()explain when they subscribe and unsubscribe.Styling:
classes.defaultapplies only to toasts without a type.Options:
importantandAction.actionButtonStyleare marked deprecated.toast():
getHistory()keeps up to 100 toasts.Migration: sonner 2.0.7 → 2.0.8.
Demos: the dialog demo no longer closes the top-layer popover before opening the modal, the counter loses its reload hint, and the site imports
PositionandThemefrom qwik-sonner.Release docs
CONTRIBUTING.md,AGENTS.mdand a comment inrelease.ymlsay to approve withpnpm stage list/pnpm stage approve.npm stagestill works.Checks
fmt.checkpasses, andbuild.types,lintand the full SSG build pass inwebsite/.topLayertoast above the modal, including when the secondary Toaster already had a toast showing before the modal opened.<Link>navigation to Examples, the counter updates.