Repository navigation
test(e2e): ✅ read the started animations without clearing them - #70
Merged
Merged
Conversation
"with several months, every grid animates" failed once in the CI (it passed on the retry): it waited for the ten rows of both grids and got none. Each read of the started animations cleared them, and expect.poll reads again and again: on a slow runner the two grids render apart, so a read between them took the rows of the first grid away, and the poll never saw all ten at once. Reading no longer clears them, and the test that counts two moves starts a new count between them. The test names don't change, so the catalog does neither.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"with several months, every grid animates" failed once in the CI (it
passed on the retry): it waited for the ten rows of both grids and got
none. Each read of the started animations cleared them, and expect.poll
reads again and again: on a slow runner the two grids render apart, so a
read between them took the rows of the first grid away, and the poll
never saw all ten at once.
Reading no longer clears them, and the test that counts two moves starts
a new count between them. The test names don't change, so the catalog
does neither.