Skip to content

test(e2e): ✅ read the started animations without clearing them - #70

Merged
diecodev merged 1 commit into
mainfrom
test/animation-started-reads
Oct 29, 2026
Merged

diecodev merged 1 commit into
mainfrom
test/animation-started-reads

Conversation

@diecodev

Copy link
Copy Markdown
Owner

"with several months, every grid animates" failed once in the CI (it
passed on the retry): it waited for the ten rows of both grids and got
none. Each read of the started animations cleared them, and expect.poll
reads again and again: on a slow runner the two grids render apart, so a
read between them took the rows of the first grid away, and the poll
never saw all ten at once.

Reading no longer clears them, and the test that counts two moves starts
a new count between them. The test names don't change, so the catalog
does neither.

"with several months, every grid animates" failed once in the CI (it
passed on the retry): it waited for the ten rows of both grids and got
none. Each read of the started animations cleared them, and expect.poll
reads again and again: on a slow runner the two grids render apart, so a
read between them took the rows of the first grid away, and the poll
never saw all ten at once.

Reading no longer clears them, and the test that counts two moves starts
a new count between them. The test names don't change, so the catalog
does neither.
@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
qwik-date Ready Ready Preview Oct 29, 2026 3:28pm UTC

@diecodev
diecodev merged commit 760e183 into main Oct 29, 2026
5 checks passed
@diecodev
diecodev deleted the test/animation-started-reads branch October 29, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant