Repository navigation
ci: 👷 check every pull request: lint, types, tests and builds - #64
Merged
Merged
Conversation
Nothing ran on pull requests: a change reached main without its lint, its types, the tests or the website build. The CI runs them on Linux, on every pull request whatever its base (in a stack each one targets the branch below it), on every push to main, and from the release workflow: biome without writing, the library's types and build, the unit tests, the website's types and build, and the e2e suite in Chromium and WebKit, one job each, with the browser cached by Playwright version. pnpm comes from packageManager (12.15.0, also pinned in the lockfile) and the install is frozen. Playwright retries once in CI instead of twice: the report marks what only passed on the retry as flaky, and two retries hid a key ordering bug. The test of Tab after changing month pressed Tab a set number of times per browser, which holds for WebKit on macOS (it skips the buttons without a tabindex) but not on Linux: it now presses it until the focus enters the grid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing ran on pull requests: a change reached main without its lint, its
types, the tests or the website build. The CI runs them on Linux, on
every pull request whatever its base (in a stack each one targets the
branch below it), on every push to main, and from the release workflow:
biome without writing, the library's types and build, the unit tests,
the website's types and build, and the e2e suite in Chromium and WebKit,
one job each, with the browser cached by Playwright version.
pnpm comes from packageManager (12.15.0, also pinned in the lockfile)
and the install is frozen. Playwright retries once in CI instead of
twice: the report marks what only passed on the retry as flaky, and two
retries hid a key ordering bug. The test of Tab after changing month
pressed Tab a set number of times per browser, which holds for WebKit on
macOS (it skips the buttons without a tabindex) but not on Linux: it
now presses it until the focus enters the grid.
Stack created with GitHub Stacks CLI • Give Feedback 💬