fix: keep JNI thread handling quiet and correct on JVM shutdown - #269
Merged
devopvoid merged 1 commit intoSep 6, 2026
Merged
Conversation
Signed-off-by: Joshua Castle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the JVM shuts down while libwebrtc threads are still running, their callbacks into Java fail to attach. The per-thread JNI helper then prints "Failed to attach thread" to stdout for each of them, and the log sink goes on to call into the null environment it got back.
This PR includes a commit by Joshua Castle (Kas-tle), who maintains a downstream fork of this library, kept under his authorship. It changes three things:
Validation on my fork: this run builds and tests on all six platforms.