fix: Update Helm chart configuration for console deployment - #663
Draft
nbmaiti wants to merge 3 commits into
Draft
fix: Update Helm chart configuration for console deployment#663nbmaiti wants to merge 3 commits into
nbmaiti wants to merge 3 commits into
Conversation
nbmaiti
force-pushed
the
fix/console_k8s_working
branch
from
August 27, 2026 03:33
0522494 to
e79b541
Compare
nbmaiti
marked this pull request as draft
August 27, 2026 03:33
There was a problem hiding this comment.
Pull request overview
Updates the Helm chart templates to make console-related deployments more environment- and namespace-friendly, aligning service discovery, health checks, and web UI configuration with the current runtime expectations.
Changes:
- Removed hardcoded
namespace: defaultto rely on the Helm release namespace. - Updated routing/service references (RPS → console, Kuma direct-access service name) and fixed console readiness probe path to
/healthz. - Improved web UI nginx SPA routing and introduced
gateway.publicUrlfor externally-reachable API base URLs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/values.yaml | Adds new gateway.publicUrl configuration knob for browser-facing host configuration. |
| charts/templates/webui.yaml | Adds SPA try_files fallback and switches API URL env vars to gateway.publicUrl. |
| charts/templates/rps.yaml | Removes hardcoded namespace and repoints RPS_MPS_SERVER to the console service. |
| charts/templates/mpsrouter.yaml | Removes hardcoded namespace and fixes Kuma direct-access service annotation to be namespace-aware. |
| charts/templates/kong.yaml | Removes hardcoded namespaces and cleans up YAML formatting/whitespace. |
| charts/templates/console.yaml | Removes hardcoded namespace, updates readiness probe path, and replaces legacy CONSOLE_* env vars with new grouped configuration. |
| chart-fixes.diff | Adds a patch artifact file mirroring the PR changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+77
to
+81
| env: | ||
| - name: "MPS_SERVER" | ||
| value: "https://{{.Values.console.commonName}}/mps" | ||
| value: "https://{{ .Values.gateway.publicUrl }}/mps" | ||
| - name: "RPS_SERVER" | ||
| value: "https://{{.Values.console.commonName}}/rps" | ||
| value: "https://{{ .Values.gateway.publicUrl }}/rps" |
Comment on lines
+54
to
+58
| - name: "APP_ENCRYPTION_KEY" | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: console | ||
| key: appEncryptionKey |
Comment on lines
+1
to
+5
| diff --git a/charts/templates/console.yaml b/charts/templates/console.yaml | ||
| --- a/charts/templates/console.yaml 2026-08-27 08:14:25.235265906 +0530 | ||
| +++ b/charts/templates/console.yaml 2026-08-27 08:14:25.231152706 +0530 | ||
| @@ -26,7 +26,6 @@ | ||
| kind: Deployment |
- Remove explicit namespace defaults to use Helm release namespace - Update console health check endpoint to /healthz - Rename environment variables to match new application configuration: - CONSOLE_* prefixed vars → APP_* or AUTH_* based on purpose - HTTP_*, LOG_LEVEL, DB_* for infrastructure settings - SECRETS_* for vault configuration - Add new environment variables: APP_ENCRYPTION_KEY, APP_DISABLE_CIRA - Update mpsrouter to reference console service with proper namespace template - Fix RPS_MPS_SERVER to point to console instead of mps - Update webui nginx configuration for SPA routing with try_files - Use gateway.publicUrl for web UI API endpoints - Fix lint issues: remove trailing whitespace Signed-off-by: Nabendu Maiti <[email protected]>
- webui: fall back to console.commonName when gateway.publicUrl is unset instead of rendering "https://<no value>/mps". Both are resolved through a new installServersChart.publicUrl helper that fails with a clear message when neither is set and webui is enabled. - secrets: define the console and consoleweb Secrets in charts/secrets.yaml. Both were already referenced by console.yaml but never provisioned; this also documents the newly required appEncryptionKey (32 chars, AES-256). - Remove chart-fixes.diff, an intermediate patch artifact that should not have been committed. Signed-off-by: Nabendu Maiti <[email protected]>
nbmaiti
force-pushed
the
fix/console_k8s_working
branch
from
August 27, 2026 04:34
0643aa5 to
c8da7ff
Compare
values-cloud.yaml enables webui but didn't set gateway.publicUrl or console.commonName, causing helm template to fail. Added a placeholder default to gateway.publicUrl in values-cloud.yaml, and simplified the helper to just use the fallback logic without strict validation (the values files now provide sensible defaults/placeholders). Verified: - helm template console charts -f charts/values-cloud.yaml ✓ - helm lint ✓ - Fallback to console.commonName still works when publicUrl not set ✓ Signed-off-by: Nabendu Maiti <[email protected]>
nbmaiti
force-pushed
the
fix/console_k8s_working
branch
from
August 27, 2026 05:45
9832aa2 to
88a6bb2
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664
Issues Addressed
namespace: defaultin manifests prevents flexible multi-namespace deploymentsCONSOLE_*prefixed variables don't match current application configuration schema/api/v1/healthendpoint doesn't exist; should use/healthzSolutions Implemented
namespace: defaultto inherit from Helm release contextAPP_*,AUTH_*,HTTP_*,DB_*,SECRETS_*console_{{ .Release.Namespace }}_svc_3000; fixed RPS_MPS_SERVER to point to console/api/v1/healthto/healthztry_files $uri $uri/ /index.html;for SPA support; replaced hardcoded commonName with{{ .Values.gateway.publicUrl }}Changes
gateway.publicUrlconfiguration optionTesting Checklist