refactor(cira): remove no-op InsecureSkipVerify from server TLS config - #1225
Merged
Conversation
InsecureSkipVerify only affects client-side verification and is dead configuration on this server-side tls.Config; client certs are never requested and device auth happens at the APF USERAUTH layer.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
=======================================
Coverage 50.81% 50.81%
=======================================
Files 149 149
Lines 13873 13872 -1
=======================================
Hits 7049 7049
+ Misses 6220 6219 -1
Partials 604 604 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rsdmike
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InsecureSkipVerify only affects client-side verification and is dead configuration on this server-side tls.Config; client certs are never requested and device auth happens at the APF USERAUTH layer.