refactor: expose activated/discovered stats and device filters by ShradhaGupta31 · Pull Request #1214 · device-management-toolkit/console

ShradhaGupta31 · 2026-08-24T05:26:46Z

Addresses: #1210

ADR: https://github.com/device-management-toolkit/console/wiki/API-contract-update-&-DB-query-mechanism-to-fetch-Device-Stats

Add activatedCount and discoveredCount to the device stats response, and
Add support ?activated=true / ?discovered=true filtering on the devices list endpoint
Implements the Stats API exposure and Devices filtering across all three storage backends (Postgres, SQLite, MongoDB),
Update OpenAPI/Fuego declarations and Postman collection entries.

Stats API responses:

$ curl -sk "https://localhost:8181/api/v1/devices/stats" -H "Authorization: Bearer $TOKEN" | jq .
{
  "totalCount": 10,
  "connectedCount": 0,
  "disconnectedCount": 0,
  "activatedCount": 6,
  "discoveredCount": 4
}

API to filter using Activated/Discovered
curl -sk "https://localhost:8181/api/v1/devices?discovered=true" -H "Authorization: Bearer $TOKEN" | jq .
curl -sk "https://localhost:8181/api/v1/devices?activated=true" -H "Authorization: Bearer $TOKEN" | jq .

codecov · 2026-08-24T05:29:40Z

Codecov Report

❌ Patch coverage is 58.59031% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.94%. Comparing base (e17b536) to head (a33dec0).

Files with missing lines	Patch %	Lines
internal/mocks/devicemanagement_mocks.go	0.00%	56 Missing ⚠️
internal/usecase/sqldb/device.go	76.62%	9 Missing and 9 partials ⚠️
internal/usecase/nosqldb/mongo/device.go	72.00%	7 Missing and 7 partials ⚠️
internal/controller/openapi/devices.go	0.00%	4 Missing ⚠️
internal/usecase/devices/repo.go	91.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                       Coverage Diff                       @@
##           denormalize-mode-discovered    #1214      +/-   ##
===============================================================
+ Coverage                        50.82%   50.94%   +0.11%     
===============================================================
  Files                              149      149              
  Lines                            13876    14101     +225     
===============================================================
+ Hits                              7053     7184     +131     
- Misses                            6219     6296      +77     
- Partials                           604      621      +17

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR extends the v1 Devices APIs to expose activated and discovered device state metrics in the stats response, and adds query-parameter filtering (?activated=true, ?discovered=true) to the devices list endpoint, wiring the behavior through the devices use case, repository interface, and both SQL + Mongo backends, with accompanying OpenAPI and Postman updates.

Changes:

Add activatedCount and discoveredCount to GET /api/v1/devices/stats.
Add ?activated=true / ?discovered=true filtering to GET /api/v1/devices.
Implement repository + usecase support for activated/discovered queries and counts, including SQL and Mongo implementations, plus tests and API tooling updates.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/usecase/sqldb/device.go	Adds SQL-backed repo methods for activated/discovered listing and state counts.
internal/usecase/sqldb/device_test.go	Adds unit tests for new SQL repo filtering/counting behavior.
internal/usecase/nosqldb/mongo/fields.go	Adds Mongo field/operator constants needed for new filters.
internal/usecase/nosqldb/mongo/device.go	Adds Mongo-backed repo methods for activated/discovered listing and state counts.
internal/usecase/nosqldb/mongo/device_test.go	Adds unit tests for new Mongo repo methods.
internal/usecase/devices/repo.go	Adds usecase methods to expose repo activated/discovered queries/counts as DTOs.
internal/usecase/devices/repo_test.go	Adds usecase-level tests for the new methods.
internal/usecase/devices/interfaces.go	Extends the repository + feature interfaces with activated/discovered methods.
internal/mocks/devicemanagement_mocks.go	Regenerates mocks to include the new interface methods.
internal/entity/dto/v1/device.go	Extends device stats DTO with activated/discovered counts.
internal/controller/openapi/devices.go	Updates OpenAPI to document new query params and stats fields.
internal/controller/httpapi/v1/devices.go	Implements stats expansion and device list filtering in the Gin handlers.
internal/controller/httpapi/v1/devices_test.go	Adds controller tests for new filtering and stats behavior.
integration-test/collections/console_mps_apis.postman_collection.json	Updates Postman collection tests/requests for new fields and filters.

Files not reviewed (1)

internal/mocks/devicemanagement_mocks.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

madhavilosetty-intel · 2026-08-24T18:18:59Z

+		return nil, ErrDeviceDatabase.Wrap(op, "r.Pool.Query", err)
+	}
+
+	if rows.Err() != nil {


rows.Err() is checked before iterating, and rows.Close() is deferred after that check. This could leave rows unclosed on error. Also, there is no rows.Err() check after the loop. Can we use the same pattern as GetByColumn and GetByTags?

Updated. Defer is now placed after all row fetch related checks are done.

sudhir-intc

Initial comments. but need to test these changes.

sudhir-intc · 2026-08-25T15:44:24Z

+	// Legacy rows with a NULL currentmode and the "not activated" sentinel are excluded.
+	activatedWhere = "currentmode IS NOT NULL AND currentmode <> '' AND LOWER(currentmode) <> 'not activated'"
+	// discoveredWhere matches devices flagged as discovered on the network.
+	discoveredWhere = "discovered = ?"


My understanding is that devices which are not yet activated would part of the discoveredWhere so it would the reverse of activatedWhere

Updated logic

sudhir-intc · 2026-08-26T08:16:23Z

 		fuego.OptionQuery("method", "Method to filter tags (any/all)"),
 		fuego.OptionQuery("hostname", "Filter devices by host name"),
 		fuego.OptionQuery("friendlyName", "Filter devices by friendly name"),
+		fuego.OptionQueryBool("activated", "Return only devices provisioned into an AMT control mode"),


Suggested change

fuego.OptionQueryBool("activated", "Return only devices provisioned into an AMT control mode"),

fuego.OptionQueryBool("activated", "Return devices activated into client or admin control mode"),

sudhir-intc · 2026-08-26T08:16:51Z

 		fuego.OptionQuery("hostname", "Filter devices by host name"),
 		fuego.OptionQuery("friendlyName", "Filter devices by friendly name"),
+		fuego.OptionQueryBool("activated", "Return only devices provisioned into an AMT control mode"),
+		fuego.OptionQueryBool("discovered", "Return only devices discovered on the network"),


Suggested change

fuego.OptionQueryBool("discovered", "Return only devices discovered on the network"),

fuego.OptionQueryBool("discovered", "Return devices discovered on the network but not yet activated"),

sudhir-intc · 2026-08-26T08:19:47Z

+func discoveredFilter(tenantID string) bson.M {
+	return bson.M{
+		fieldTenantID:   tenantID,
+		fieldDiscovered: true,


We could use fieldCurrentMode and check for not-activated here. This depends on the comment given in the other PR related to denormalize to check if discovered field is really needed?

Please review comment & confirm if this change is needed

Yes lets remove the fieldDiscovered here and use fieldCurrentMode

Addresses: #1210 - Add activatedCount and discoveredCount to the device stats response, and - Add support ?activated=true / ?discovered=true filtering on the devices list endpoint - Implements the Stats API exposure and Devices filtering across all three storage backends (Postgres, SQLite, MongoDB), - Update OpenAPI/Fuego declarations and Postman collection entries.

- modified discovered device modify logic Signed-off-by: ShradhaGupta31 <[email protected]>

ShradhaGupta31 force-pushed the activated-discovered-filter-api branch 2 times, most recently from e30d3e3 to 6aef488 Compare August 24, 2026 08:31

ShradhaGupta31 marked this pull request as ready for review August 24, 2026 14:13

ShradhaGupta31 requested a review from a team as a code owner August 24, 2026 14:13

ShradhaGupta31 requested a lite review from Copilot August 24, 2026 14:13

Copilot started reviewing on behalf of ShradhaGupta31 August 24, 2026 14:14 View session

Copilot AI reviewed Aug 24, 2026

View reviewed changes

Comment thread internal/usecase/nosqldb/mongo/device.go

Comment thread internal/usecase/sqldb/device_test.go Outdated

madhavilosetty-intel reviewed Aug 24, 2026

View reviewed changes

ShradhaGupta31 force-pushed the activated-discovered-filter-api branch 2 times, most recently from 12984d5 to a4002ea Compare August 25, 2026 14:29

ShradhaGupta31 requested a review from madhavilosetty-intel August 25, 2026 15:20

sudhir-intc reviewed Aug 25, 2026

View reviewed changes

sudhir-intc reviewed Aug 26, 2026

View reviewed changes

ShradhaGupta31 force-pushed the denormalize-mode-discovered branch 2 times, most recently from c20cd8b to 7034e21 Compare August 27, 2026 10:37

ShradhaGupta31 force-pushed the activated-discovered-filter-api branch from a4002ea to 74e74a4 Compare August 28, 2026 13:27

ShradhaGupta31 force-pushed the denormalize-mode-discovered branch from 7034e21 to e17b536 Compare August 28, 2026 13:32

ShradhaGupta31 force-pushed the activated-discovered-filter-api branch from a8ce286 to a33dec0 Compare August 28, 2026 13:44

ShradhaGupta31 added 2 commits August 28, 2026 19:21

refactor: addressed review comments

a33dec0

- modified discovered device modify logic Signed-off-by: ShradhaGupta31 <[email protected]>

	fuego.OptionQueryBool("activated", "Return only devices provisioned into an AMT control mode"),
	fuego.OptionQueryBool("activated", "Return devices activated into client or admin control mode"),

	fuego.OptionQueryBool("discovered", "Return only devices discovered on the network"),
	fuego.OptionQueryBool("discovered", "Return devices discovered on the network but not yet activated"),

Uh oh!

Conversation

ShradhaGupta31 commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudhir-intc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ShradhaGupta31 commented Aug 24, 2026 •

edited

Loading

codecov Bot commented Aug 24, 2026 •

edited

Loading