Repository navigation
starlark: pins.json and dx_pins extension; ruby and powershell first (part of #10144) - #10152
Draft
TrapsterDK wants to merge 1 commit into
Draft
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
…nto it (part of #10144) Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10144. Stacked on #10134 (base toolchain-factory-10065); retarget to main once it merges.
Changed:
dx_pinsextension in libs/starlark/toolchain.bzl with apintag (name, pins, build, toolchain_type, aliases): per-cell repos plus a toolchain hub, or one host-selected repo when no toolchain_type. Also exposes@dx_pins_data//:pins.bzlfor tests.ruby/toolchain/pins.jsonandpowershell/toolchain/pins.json; their pins.bzl and powershell repos.bzl are deleted. Powershell cells were already host-cell names.//libs/starlark:pins_testrunspin_checksover every pins.json; per-language tests keep their own checks.Remaining:
Tested: bazel test //libs/starlark:pins_test //libs/starlark/tests:cells //libs/starlark/tests:toolchain //ruby/toolchain:metadata //powershell/toolchain:metadata pass; @dx_sorbet and pwsh repos fetch, sorbet runs. Nested-Bazel and consumer tests were not run.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B