Repository navigation
config: more compiled languages honour //config:warnings_as_errors (part of #10075) - #10147
Draft
TrapsterDK wants to merge 1 commit into
Draft
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
…gs_as_errors (part of #10075) Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10075.
Done:
warnings = (attr, on, off)and append the flag-driven value to the upstream attribute. Upstream targets no longer receivewarnings_as_errors.-Dwarningsin rustc_flags), swift (-warnings-as-errors), d (-w), fortran (-Werror), go (-Werrorin copts when cgo is on), erlang (-Werrorin erlc_opts).//libs/starlark/tests:warnings_parity_test(and one in families/dotnet) lists every compiled language. zig, typescript and dart are explicit opt-outs.Remaining:
<lang>/rules/to<lang>/private/with package-private visibility and@rules_dx//<lang>:defs.bzlas the public API.Checked: warnings_parity_test and the warnings analysis tests pass; build --nobuild on //rust/... //go/... //swift/... //d/... //fortran/... //erlang/... succeeds.
Not run: compiling existing rust, swift, d, fortran and erlang targets (remote cache errors, timeout), nested-Bazel and consumer tests, the tools/dx check gate (its tool build failed locally).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B