Repository navigation
dx_process: shared git and bounded capture helpers (part of #10054) - #10132
Draft
TrapsterDK wants to merge 2 commits into
Draft
TrapsterDK wants to merge 2 commits into
TrapsterDK wants to merge 2 commits into
Conversation
Add dx_process::capture with git(), run_captured(), run_checked() and run_captured_with_input(): one timeout, stderr capture, RunError and git env scrubbing. Move the direct git and tool launches in cli/, deploy/rules and the worktree crate onto them. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
…elper (part of #10054) Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10054
Adds
dx_process::capture(git(cwd),run_captured,run_checked,run_captured_with_input,RunError) with one timeout, stderr capture, a shared error type and git env scrubbing.run_command_with_inputinlifecyclefeeds stdin.Moved onto it: umbrella, adopt (scaffold, build_output, git_changes, preset, families), config, upgrade, bench, update_pr, update_outdated, audit, image_scan, tool_resolve, go_api, api_compat, and the worktree git runner.
Tests: new
capture_tests.rscovers timeout, spawn failure, stderr capture, output bound, stdin and git env. Passed locally://cli/process:dx_process_test,//cli/worktree:all,//cli/tool_resolve:all,//cli/audit:dx_audit_test,//cli/adopt:all,//deploy/rules:dx_deploy_tools_test,//cli/cli:dx_cli_test.Not run: clippy/lint (a
dx lintrun was stopped after a long wait),dx check --affected(generate fails on unrelated consumer fixtures), nested-Bazel and consumer tests.Remaining for #10054:
Command::new("git")in upgrade/config/init tests, crates.rs, pypi.rs, npm.rs, go_api.rs tests.cli/adopt/src/launcher.rsandcli/plan/src/slots.rs.Latest commit also moved github.rs notes git, and the umbrella, audit_live, generated_drift, scaffold and build_output test git calls. Passed:
//cli/adopt:dx_adopt_test,//deploy/rules:dx_deploy_tools_test,//cli/cli:dx_cli_test. Lint not run.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B