Repository navigation
Conversation
Remove invalid date suffixes from Sonnet and Opus; verify actual SDK model payloads with local fixtures. Generated-with: gpt-6.1-sol
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AI assistant sends
claude-sonnet-4-6-20250514by default andclaude-opus-4-6-20250514when Opus is selected. These identifiers mix the 4.6 generation with an older snapshot date. Anthropic documents the canonical IDs asclaude-sonnet-4-6andclaude-opus-4-6.Correct those two enum values. Keep Haiku 4.5 and the surrounding request behavior unchanged. Add three fixture-only regressions that exercise AIService.complete and inspect the actual SDK model/message payload for the default, Opus and Haiku selections. Record the correction under Unreleased; no product version change.
Primary reference: https://platform.claude.com/docs/en/about-claude/models/model-ids-and-versions
Validation on Windows Python 3.12 / pytest 9.1.1:
Author model: gpt-6.1-sol (Codex). Draft pending independent review; merges disabled. Based directly on master 49d7a83, independent of the action-upgrade PR #8. Canonical worktree and OneDrive deployment stay on their existing states until reviewed integration.