Repository navigation
DLPX-100122 Catalog npm lock files and embedded CycloneDX documents in package SBOMs - #422
Draft
suyash-jai wants to merge 1 commit into
Draft
suyash-jai wants to merge 1 commit into
suyash-jai wants to merge 1 commit into
Conversation
suyash-jai
marked this pull request as ready for review
October 29, 2026 12:23
suyash-jai
force-pushed
the
dlpx/pr/suyash-jai/4c744b26-a8b4-4735-ae27-b65bb09d6a0b
branch
from
October 29, 2026 12:23
f781095 to
8a74007
Compare
suyash-jai
marked this pull request as draft
October 29, 2026 12:32
suyash-jai
force-pushed
the
dlpx/pr/suyash-jai/4c744b26-a8b4-4735-ae27-b65bb09d6a0b
branch
from
October 29, 2026 12:53
8a74007 to
26a6055
Compare
suyash-jai
force-pushed
the
dlpx/pr/suyash-jai/4c744b26-a8b4-4735-ae27-b65bb09d6a0b
branch
from
October 30, 2026 05:51
26a6055 to
b24e6cc
Compare
…n package SBOMs PR URL: https://www.github.com/delphix/linux-pkg/pull/422 Co-Authored-By: Claude Opus 5.5 <[email protected]>
suyash-jai
force-pushed
the
dlpx/pr/suyash-jai/4c744b26-a8b4-4735-ae27-b65bb09d6a0b
branch
from
October 30, 2026 07:36
b24e6cc to
c4eb7f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.deb, so Java components are the jars the package ships. For the UIs, onlypackage.jsondependenciesare listed, notdevDependencies; the CSV does include devDependencies. Caveat: an npm runtime dependency is listed even if webpack leaves it out of the bundle.What this PR changes
A package's browser UI ships as minified bundles that Syft cannot see into, so the virtualization SBOM listed no npm components. This adds
catalog_npm_lockfiles(), which scans each shipped lock file's directory on its own (Syft separates runtime from dev dependencies only at the scan root) with licenses fromSBOM_NPM_REGISTRY, and adds+javascript-package-cataloger,+sbom-catalogerto the main scan. Of the other 31 deep-scanned .debs of #13252, only delphix-rust-src changes (+2 components).Jira: DLPX-100122. Sub-task of DLPX-100120 (epic CP-13455), delivered in three PRs:
docs/specs/2026-10-26-sbom-phase4-evaluation.md)*.DESC.json, in delphix-virtualizationDetails: the full CSV comparison
Compared with the CSV from stage0 pre-push #13252 (
bom-internal-qa-aws.csv, productVirtualization). Before is #13252; after is #15738 with these changes.The 24 names:
spring-boot-starter-*"Not shipped" was checked against the file list of the
.deband of every.warin it. less.js 3.9.0 is inbom.csvbut dropped from the per-variant CSVs, apparently because the Ubuntu pager is also calledless; it ships indxcore.warand is now listed. Againstbom.csvthe CSV-only names are the same 24.Third-party code that ships but is in neither the CSV nor the SBOM (jqTree, jquery.smooth-scroll, jasmine-jquery, rsync, PostgreSQL xlogdump, inih, jsmn, fonts, angular-mocks, angular-i18n, Glyphicons) is left to DLPX-100126.
🤖 Generated with Claude Code