[DeepCompile] Fix staticmethod handling on Python 3.9 - #8240
Open
baremetaldevx86 wants to merge 1 commit into
Open
[DeepCompile] Fix staticmethod handling on Python 3.9#8240baremetaldevx86 wants to merge 1 commit into
baremetaldevx86 wants to merge 1 commit into
Conversation
Signed-off-by: Vedant Chauhan <[email protected]>
baremetaldevx86
requested review from
loadams,
tjruwase and
tohtana
as code owners
August 9, 2026 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DeepCompile retrieves PyTorch's compiled backward hooks directly from the class namespace. On Python 3.9, this returns a
staticmethoddescriptor that cannot becalled directly, resulting in:
This change unwraps the underlying function before DeepSpeed invokes it.
The fix covers both supported implementations:
_backward_prologue_backward_implA regression test emulates Python 3.9's non-callable
staticmethodbehavior so the failure remains covered when CI runs on newer Python versions.Testing
pytest -q tests/unit/compile/test_backend.py tests/unit/compile/test_zero3_grad_dtype.pypre-commit run --files deepspeed/compile/patch_compiled_func.py tests/unit/compile/test_backend.pyFixes #7433