Repository navigation
Conversation
Signed-off-by: Maya Kid <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When its only tool call finishes, StepGroup replaces the grouped StepRow with a new standalone row. This closes details the user is reading and removes the focused button, sending keyboard focus to the page body.
What changes
Keep a single call in the same StepRow throughout its status changes, keyed by the call's id so another call starts closed. A single running call now shows its own row instead of an extra one-step group; multiple calls keep their existing grouping.
Extend the existing tool-steps demo with timed success and failure controls so the transition can be inspected. No new public API, example name, or error/patch rendering behavior is introduced.
How it was checked
npm ci,npm run docs,npm run typecheck, andnpm run buildpass./dev/examplesreports 389/389 mounted and 0 failed in both themes, without page errors.Before review
git commit -s)npm run typecheckandnpm run buildpass/dev/examplesreports0 failedsrc/examples/and its page incontent/solid/