Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
".": "0.0.0"
}
Comment on lines +1 to +3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Set manifest to the real last released version

Setting the root to 0.0.0 tells release-please that the most recent release was 0.0.0, so the very next PR will try to tag a brand-new 0.x version and ignore the existing 4.x history. Please seed the manifest with the actual current version (today that’s 4.8.1) so the generated release cadence stays aligned with what’s already on PyPI. (github.com)

Apply this diff to fix the initial version:

-  ".": "0.0.0"
+  ".": "4.8.1"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
".": "0.0.0"
}
{
".": "4.8.1"
}
🤖 Prompt for AI Agents
In .release-please-manifest.json around lines 1 to 3 the manifest seeds the root
version as "0.0.0", which will make release-please ignore existing 4.x history;
update the manifest to the actual last released version by replacing "0.0.0"
with "4.8.1" so future releases continue from the correct version.

12 changes: 12 additions & 0 deletions release-please-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"packages": {
".": {
"changelog-path": "CHANGELOG.md",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"prerelease": false
}
Comment on lines +2 to +9

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Declare the Python release strategy

Without an explicit release-type, release-please defaults this component to node, which will skip all of the Python-version bumping logic and leave files like pyproject.toml untouched. Add the Python release type (and the matching package name) so the bot edits the correct artifacts. (github.com)

Apply this diff to align the configuration with the Python SDK:

-    ".": {
+    ".": {
+      "release-type": "python",
+      "package-name": "deepgram-sdk",
       "changelog-path": "CHANGELOG.md",
       "bump-minor-pre-major": false,
       "bump-patch-for-minor-pre-major": false,
       "draft": false,
       "prerelease": false
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"packages": {
".": {
"changelog-path": "CHANGELOG.md",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"prerelease": false
}
"packages": {
".": {
"release-type": "python",
"package-name": "deepgram-sdk",
"changelog-path": "CHANGELOG.md",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"prerelease": false
}
🤖 Prompt for AI Agents
In release-please-config.json around lines 2 to 9, the package entry lacks a
release-type and package-name so release-please defaults to node and won't
update Python artifacts; add "release-type": "python" and "package-name":
"<your-python-package-name>" (replace with the actual PyPI/package identifier
used in pyproject.toml) to the "." package object so the releaser runs
Python-specific bumping and edits pyproject.toml and other Python files.

},
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}