Skip to content

fix(skills): jira-validate-production opens a follow-up issue instead of reopening a merged card - #7767

Merged
viktormarinho merged 1 commit into
mainfrom
fix/jira-validate-production-followup
Oct 7, 2026
Merged

viktormarinho merged 1 commit into
mainfrom
fix/jira-validate-production-followup

Conversation

@viktormarinho

@viktormarinho viktormarinho commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

What is this contribution about?

Three changes to the jira-validate-production skill, all from running it as a scheduled post-deploy check:

  • A failed validation opens a follow-up issue instead of sending the card back. The skill sent a failed card back to the implementing column and told the next run to amend the fix, but by then the card's pull request is merged, so there is nothing to continue: the next run either pushes to a closed branch or improvises. The card now stays where it is, and the fix is tracked in a new issue relatesTo the original (or a comment on an open one that already relates to it), moved to the implementing column so it starts from the default branch. The verdict comment on the original names the follow-up. When the failure breaks the site for its users, both comments point at reverting the card's merge commit; the run does not revert.
  • A deploy that is not live yet gets no comment. It is not a verdict, and a comment there reads as one to whatever decides which cards still need validating (a person scanning the column, or an automation that skips cards with a verdict). The run leaves the card untouched and says so in its final message.
  • A run with several issues works through them itself. In one run over a batch, the agent handed the issues to background agents and ended its turn; the run completed with none of them validated. The skill now says to do them in the run.

Team skills can still set the follow-up's title and type (e.g. a hotfix prefix).

How did you verify your code works?

  • bun test packages/sandbox/image/skills/manual-skills.test.ts: 8 pass (the skill stays manual-only).
  • bun run verify: 10,296 pass, 0 fail.
  • The batch failure above was a real run: one validation run over 17 issues spawned four background agents and completed in under a minute without validating or commenting on any issue.

How to Test

  1. Start a run with this skill on a merged issue whose change is missing in production: it opens a follow-up issue related to it, in the implementing column, and comments on the original without moving it.
  2. Start one on an issue whose merge has not deployed yet: no comment, no move, and the final message says the deploy is not live.

Review Checklist

  • PR title is clear and descriptive
  • Changes are tested and working
  • Documentation is updated (if needed)
  • No breaking changes

Summary by cubic

Reworks the jira-validate-production skill for scheduled post-deploy runs: failed validations now open a follow-up issue instead of sending the merged card back, and deploys that are not live yet are left without a comment.

  • A failed validation keeps the card in place and tracks the fix in a new issue relatesTo the original (or comments on an open one), moved to the implementing column so the fix starts from the default branch.
  • The verdict comment on the original names the follow-up; when the failure breaks the site for its users, both comments point at reverting the merge commit, but the run does not revert.
  • A deploy still in progress gets no comment or move, since a comment would read as a verdict; the final message says validation waits for the deploy.
  • Runs with several issues now validate them all in the same run instead of handing them to background agents, which end with the run's turn.

Written for commit 9c36073. Summary will update on new commits.

Review in cubic Turn on auto-fix

… of reopening a merged card

A failed validation sent the card back to the implementing column so the next
run would continue its pull request, but that pull request is already merged.
The skill now leaves the card where it is and tracks the fix in a new issue
related to it (or comments on an open one), moved to the implementing column so
the fix starts from the default branch.

A deploy that is not live yet no longer gets a comment: it is not a verdict,
and a comment there reads as one to anything deciding which cards still need
validating. And a run given several issues works through them itself instead of
handing them to background agents, which end with the run's turn.
@viktormarinho
viktormarinho merged commit d2857bb into main Oct 7, 2026
32 checks passed
@viktormarinho
viktormarinho deleted the fix/jira-validate-production-followup branch October 7, 2026 03:18
decocms Bot pushed a commit that referenced this pull request Oct 7, 2026
PR: #7767 fix(skills): jira-validate-production opens a follow-up issue instead of reopening a merged card
Bump type: patch

- @decocms/sandbox (packages/sandbox/package.json): 1.82.1 -> 1.82.2
- deploy/helm/sandbox-env (chart 0.20.30) (deploy/helm/sandbox-env/values.yaml deploy/helm/sandbox-env/Chart.yaml): image.tag/appVersion -> 1.82.2

Deploy-Scope: both
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant