Repository navigation
test(github): pin the clock for repo grant refresh tests - #554
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven GitHub repo-grant tests started failing after September 8, 2026: their seeded grants expire on that date, but the refresh calls defaulted to the real clock. They returned
invalid_grantbefore reaching permission fallback, token minting or upstream error handling. Some invalid-grant tests also passed for the wrong reason.Pass the fixture's June 10 clock through the existing
nowparameter in every refresh test that omitted it. Production code and grant expiry behavior are unchanged.This failure reproduced on unchanged
mainatb30f645, independently of the catalog changes in #553. The catalog PR was merged separately as requested.Validation:
bun test github/server/lib/repo-grant.test.tsproduced the same seven CI failures on both the catalog branch and unchangedmain.bun run check github, formatting, lint andgit diff --checkpass. The repository type-check command filters dependency-source diagnostics; a directtsc --noEmitreports those dependency errors. Lint has warnings in existing MCP implementations.