Repository navigation
feat(apps-nuvemshop): customer profile, addresses and orders - #635
Open
JonasJesus42 wants to merge 2 commits into
Open
JonasJesus42 wants to merge 2 commits into
JonasJesus42 wants to merge 2 commits into
Conversation
…actions Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…-out coverage Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the account endpoints from deco-sites/reserva-nuvemshop#5 into
@decocms/apps-nuvemshop:account/profile,account/addresses,account/orders,account/orderaccount/updateProfile,account/addAddress,account/updateAddress(store form, avoids duplicate)sessionCustomerId()instore.ts(exported);loaders/usernow uses it. TheLS.customerscrape fails closed unless all matches agree.manifest.gen.ts(hand-maintained in this package) and the barrel;./loaders/*and./actions/*exports already resolve.references/account.md.Security invariants (tested in
accountData.test.ts)parseId; ownership via String compare; not-yours == not-found (404, same message).nuvemshopAdmin,cache = no-store).Unsupported operations
Address delete/default, logged-in password change, password recovery (store reCAPTCHA).
Notes
admin.tsholds no secrets and the barrel was already server-only (store/RequestContext); documented, no code change.workerEntry.test.ts(2), biome lint in tanstack/algolia, knip devDep-binary warnings.Test plan
bun run testin apps-nuvemshop (115 pass), typecheck and biome clean for the package, secrets audit OK, skills:check OKsrc/platform/accountinline copiesSite PR: https://github.com/deco-sites/reserva-nuvemshop/pull/5
🤖 Generated with Claude Code
Summary by cubic
Ports the Nuvemshop customer account endpoints (profile, addresses, orders) from the reserva-nuvemshop site into the
apps-nuvemshoppackage as loaders, actions, docs, with tests. The customer id always comes from the store session via the newsessionCustomerId(), never from props, andloaders/usernow shares that path; the session lookup is memoized per request.Security: every rule is covered by the new
accountData.test.ts.parseId. Test coverage now includes every loader and action plus a no-cookie request.cache = "no-store"over the raw Admin transport, so per-user data never hits the shared GET cache, and orders are post-filtered by the session customer.Unsupported: address delete/set-default, logged-in password change, and password recovery have no upstream support.
Written for commit 535f338. Summary will update on new commits.