docgen: detect 'cwd deleted' from claude subprocess + halt loop - #3
Merged
Conversation
Same fix as private + public mirrors — detects 'cwd was deleted' in claude subprocess stderr, marks fatal; analyzeAllParallel switched to Promise.allSettled with halt propagation so one slot's fatal error doesn't discard the others' results AND the outer loop bails instead of grinding forever; --until-done entry checks process.cwd() first. 44/44 tests pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as the two pbx-* mirrors — kills the runaway-zombie bug where the
--until-doneloop keeps retrying after the worktree gets deleted underneath docgen.The detection happens at the claude-subprocess stderr level: when claude reports
current working directory was deleted, we flag the error as fatal-batch (halt: true+code: 'CWD_DELETED'),analyzeAllParallelpropagates the halt, the outer re-walk loop exits early.Plus a pre-loop
process.cwd()check so we don't spawn the doomed claude call when our own cwd is already gone.44/44 tests pass locally.