Fix catalog validation for preview custom builds - #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first production Preview 3 custom build exposed a dispatch-only failure: the full catalog test reads prospective v3.1.14 metadata, but the workflow created its temporary local validation tag only for main requests. Include the explicitly allowed Preview 3 ref in that same validation-only condition. Real stable requests still require the real tag; nothing pushes a prospective tag.
The source remains the exact Preview 3 commit supplied by the Worker. Signing, expected combination hash, builder checks and quota limits are unchanged. Added the corresponding workflow contract assertion; local contract and diff checks passed.
Production run 34134269924 failed before compilation. This PR fixes its root cause; the failed attempt will not be reset or bypassed.