Repository navigation
Conversation
e67291c to
648c58a
Compare
|
Whipped something out really fast. Did not test this yet but I took the code from my own project (https://github.com/Tareku99/ACELink) and it worked fine there. I am out of time, but I wanted to make something before I left. |
|
Thanks Nicola, that was quick. I'd like to stay with the opt-in from your first commit: please set the defaults of v2_probe_generic_usb and enable_ace_v2 back to false, but keep the improvements from 648c58a (suspend when the configured-port list is unknown, the probe rotation). A stock setup should never send bytes to a serial port it doesn't know. Please also take out the exclusive=True in open_transport (that's the reconnect path we tested on hardware, unrelated to discovery) and the README change. Opening a port also toggles DTR, which resets some CH340 boards; could the probe open with DTR/RTS off? No rush, this can wait until you're back. Safe travels. Dirk |
Sounds good. Thank you for the feedback, shall take care of this when back in 2 weeks or so. |
Summary
falsesettings, and keepv2_probe_generic_usb: falseas an optional disable switch.DISCOVER_DEVICEandGET_INFOexchanges. Require valid CRC, command, sequence, non-zero UID, and firmware identity.v2_extra_usb_idsselection behavior.ACELink context
ACELink informed the use of
GET_INFOto confirm device identity. Its first-matching-adapter heuristic is not copied as the multiACE scanner. Automatic discovery and verification are handled by multiACE's existing V2 protocol code.Validation and remaining work
git diff --checkpassed.Refs #154