Skip to content

Environment variables for host paths: one naming convention #142

Description

@decay71

@Simon-CR @Tareku99 you are both adding environment variables for host
paths right now, from two directions: Simon in #141 (generic Klipper
hosts, path discovery in ace.py and the backend), Nicola in the
paxx-managed-package branch (bind-mounted install, PAXX owns the
paths). Let's agree on one list before either lands.

What exists on main today (backend and updater), all with the
MULTIACE_ prefix:
MULTIACE_DIR, MULTIACE_CFG_PATH, MULTIACE_FRONTEND_DIR,
MULTIACE_UPDATE_REPO, MULTIACE_UPDATE_URL_BASE, MULTIACE_UPDATE_PRERELEASE
(plus a few runtime knobs like MULTIACE_LANGUAGE, MULTIACE_WS_DEBUG).

Nicola's branch adds, same prefix:
MULTIACE_ROOT, MULTIACE_CONFIG_DIR, MULTIACE_WEB_DIR, MULTIACE_MANAGED,
MULTIACE_MANAGED_MARKER, MULTIACE_DISABLE_UPDATES,
MULTIACE_IGNORE_FIRMWARE_MANAGED.

#141 adds, without prefix:
KLIPPER_CONFIG_DIR, PRINTER_DATA.

Proposal:

  1. Everything multiACE reads keeps the MULTIACE_ prefix. The two names
    in feat(transport): two-tier transport liveness watchdog, dynamic path resolution, and reactor pause fix #141 become MULTIACE_CONFIG_DIR (already defined by Nicola, same
    meaning: the directory holding printer.cfg) and MULTIACE_PRINTER_DATA.
  2. One variable per path, read by every process that needs it (ace.py
    in Klipper, the web backend, the shell scripts). No second name for
    the same directory.
  3. Defaults stay the U1 paths, so a printer without any of these set
    behaves exactly as today.
  4. The list lives in one place in the repo (docs or a comment block in
    the backend) so the next contributor finds it.

Simon, Nicola: does that work for you, and is anything missing from the
list? Once you agree I'll merge the path half of #141 with the renamed
variables and Nicola's package can rely on the same names.

Dirk

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions