Repository navigation
Fix/popover transitions - #1
Merged
Merged
Conversation
Onboarding: tinted header card, icon per recommended option, prominent Get started button, gentle fade-in (skipped under Reduce Motion). Settings: header plus icon section headers; the Form owns scrolling instead of nesting in a ScrollView, which restored a random offset when the window opened. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The snapshot morph replaced AppKit's popover animation with a stretched image of the content. The Liquid Glass surface and arrow are composited by the window server, so the snapshot held only bare text: it floated on the desktop, squashed into a ribbon, then hard-cut to the real popover. Use AppKit's native zoom from the menu-bar item instead. Expanding a provider snapped the window to its new height in one frame while SwiftUI animated the layout over 0.25s, clipping the header and footer. The popover is now sized from SwiftUI's reported size and animated on the same curve as the layout (PopoverMotion), with the content pinned to the top. AppKit keeps isShown true ~0.5s after the zoom-out ends, and a 0.4s debounce sat on top of that, so a click within ~1s of closing was ignored. With application-defined behavior there is no double-fire to guard against; a click during the close now reopens once it lands. Also restyles the popover as cards and closes it explicitly before opening Settings or About. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.