Repository navigation
Quick Open should offer bare IPv4 addresses and localhost with a port as web links, as it does with a scheme. - #511
Merged
Conversation
link(from:) wanted a host with a dot and letters at the end, so 192.168.1.1, 192.168.1.1:8080 and localhost:3000 got no Open or Add row, while the same text with http:// did. Routers and local dev servers are typed that way. The host rule now also takes a dotted-quad address or localhost, and still rejects too few parts to be an address, an octet above 255, and a single word. A typed address gets the https default with its port kept. Spotlight.host still wants a dotted host, since a bare localhost has no domain to show, so its answer for that case is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469