Repository navigation
A library://open link with a value for a multi-field template confirms the value, then ignores it and shows the empty prompt. - #503
Merged
Conversation
linkOpenNeedsConfirmation asked for any template with a value, while open uses that value only when the template has exactly one field. A link for a two-field template confirmed "The link fills this address with: hello" and then opened the empty fields prompt, so the text named a value that was never used. The rule now matches what open does, so a multi-field template goes straight to the prompt and no confirmation quotes a value that is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the library:// link stack, on top of #502.
Closes #453
Stacked on: