Repository navigation
Pins made after the Keychain key fails at launch are never written, because the failure is never retried. - #501
Merged
Merged
Conversation
…eadable A key that failed at launch left clipboard.json and clipboard-history.json closed for the whole session, because only Reset Clipboard Key cleared the flag. A denied Keychain prompt or a locked Keychain therefore silenced every save, and pins made in that session were lost at quit with nothing but a log line. A save or pin change now reads those files again off the main actor. When one opens, its clips merge in and the waiting save goes out straight away, so the pins made meanwhile are written and the older ones are kept. A file that is still unreadable is left alone and the next change tries again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of the clipboard save stack, on top of #497, #498, #499 and #500.
Closes #470
Stacked on: