Fix modern TLS - #71
Open
mikhailnov wants to merge 2 commits into
Open
mikhailnov wants to merge 2 commits into
mikhailnov wants to merge 2 commits into
Conversation
GCC 10+ defaults to -fno-common, so the tentative definitions of
table, conf_file and Mopts in email.h (included by every .c file)
now collide at link time ("multiple definition of ...").
Declare them extern in the header and define them once in email.c.
Co-authored-by: Z.AI GLM <[email protected]>
dnetUseTls() can fail (e.g. SSL_CTX_new() error on OpenSSL 3.x, or a failed handshake), and its return value was ignored. The code then sent EHLO in plaintext right after STARTTLS, the server dropped the connection, and the user saw a confusing "Lost connection with SMTP server" instead of the real TLS error. Check the return value and report the OpenSSL error text via dnetGetErr() before aborting the send. Co-authored-by: Z.AI GLM <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-fcommonsmtp.yandex.ruand other modern servers