Fix TLS for OpenSSL 3.x: use TLS_client_method(), record error text - #9
Open
mikhailnov wants to merge 1 commit into
Open
mikhailnov wants to merge 1 commit into
mikhailnov wants to merge 1 commit into
Conversation
TLSv1_client_method() pins the protocol to TLS 1.0. On OpenSSL 3.x combined with system configs that enforce MinProtocol=TLSv1.2 (e.g. ROSA/other modern distros), SSL_CTX_new() fails outright; against servers that still allow TLS 1.0 the handshake pins an insecure protocol modern servers reject. Use TLS_client_method() on OpenSSL >= 1.1.0 (SSLv23_client_method() on older releases), which negotiates the highest mutually supported version. Also record the OpenSSL error string on every failure path inside dnetUseTls() into the socket (new errstr field, zero-initialized in dnetConnect()), and make dnetGetErr() prefer it over strerror(errno) so callers can report why the TLS setup failed instead of silently falling back to a plaintext session. Co-authored-by: Z.AI GLM <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLSv1_client_method() pins the protocol to TLS 1.0. On OpenSSL 3.x combined with system configs that enforce MinProtocol=TLSv1.2 (e.g. ROSA/other modern distros), SSL_CTX_new() fails outright; against servers that still allow TLS 1.0 the handshake pins an insecure protocol modern servers reject.
Use TLS_client_method() on OpenSSL >= 1.1.0 (SSLv23_client_method() on older releases), which negotiates the highest mutually supported version.
Also record the OpenSSL error string on every failure path inside dnetUseTls() into the socket (new errstr field, zero-initialized in dnetConnect()), and make dnetGetErr() prefer it over strerror(errno) so callers can report why the TLS setup failed instead of silently falling back to a plaintext session.
This fixes working with
smtp.yandex.ruand other modern servers.