FLPATH-4770 - fix getting started examples for multi-resource catalog items - #21
Merged
testetson22 merged 1 commit intoAug 20, 2026
Conversation
Updates the small VM catalog item and instance tutorials to reflect the new `spec.resources` schema, where each resource has a name and service type. Instance `user_values` entries now specify the target resource by name. Signed-off-by: Thomas Stetson <[email protected]>
5 tasks
testetson22
marked this pull request as ready for review
August 18, 2026 18:48
testetson22
requested review from
LinskId,
NoamNakash,
chadcrum,
gpb88 and
jordigilh
August 18, 2026 18:48
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider briefly explaining why the resource is named
mainin the example (e.g., a common convention) to help users choose meaningful names for multi-resource catalog items. - In the catalog item tutorial, you might add a short note or example showing how multiple resources would look (even just a second stub resource) to make the new multi-resource schema clearer for users who will define more complex items.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider briefly explaining why the resource is named `main` in the example (e.g., a common convention) to help users choose meaningful names for multi-resource catalog items.
- In the catalog item tutorial, you might add a short note or example showing how multiple resources would look (even just a second stub resource) to make the new multi-resource schema clearer for users who will define more complex items.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
PR Summary by QodoFix Getting Started examples for multi-resource catalog items
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can keep summaries lean with Finding overflow, which tucks the rest behind 'View more' |
testetson22
added a commit
to dcm-project/cli
that referenced
this pull request
Sep 17, 2026
…low (#31) [FLPATH-4770](https://redhat.atlassian.net/browse/FLPATH-4770): The CLI's `go.mod` pinned `control-plane` to a commit predating the multi-resource schema change (FLPATH-4384). This caused `parseInputFileAs` to silently drop the `spec.resources` field during YAML → JSON serialization, making it impossible to create catalog items via `dcm catalog item create`. check-website-fixtures action is expected to fail until the [dcm-project.github.io PR](dcm-project/dcm-project.github.io#21) is merged. ## Changes - Bump `github.com/dcm-project/control-plane` to latest `main` so the CLI's generated types include the `Resources` field required by the multi-resource catalog item schema - Add static contract tests (TC-U154, TC-U155) that validate the CLI correctly serializes documented tutorial YAMLs to the API - Add `testdata/website/` fixtures mirroring the Getting Started tutorial examples - Add `hack/check-website-fixtures.sh` script + CI workflow to detect drift between local fixtures and the upstream website repo ## Depends on - dcm-project/dcm-project.github.io#21 - Website: updates tutorial YAMLs to multi-resource schema (`dcm-project/dcm-project.github.io` branch `FLPATH-4770-fix-user-journey`) ## Test plan - [x] `go test ./...` passes (151 specs including 2 new contract tests) - [x] Contract tests validate the exact YAML→JSON serialization path that was broken - [x] `hack/check-website-fixtures.sh` correctly detects drift (verified locally) - [x] ShellCheck passes on the script - [x] `hugo --minify` confirms companion website changes render correctly ## Related - [FLPATH-4794](https://redhat.atlassian.net/browse/FLPATH-4794) — Add CLI-to-API contract tests to prevent silent schema drift --------- Signed-off-by: Thomas Stetson <[email protected]> Co-authored-by: Cursor AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Getting Started tutorials still used the old schema, causing users to get HTTP 400 errors when following the documented steps.
The control-plane's catalog item schema was updated (FLPATH-4384) to require
spec.resources(an array of named resource definitions) instead of the flatspec.service_type/spec.fieldsstructure. The instance schema now requiresuser_values[].resourceto specify which resource each value applies to.Changes
small-vm.yamlexample to use the multi-resource schema (spec.resources[]) introduced by control-plane PR docs: add missing enhancement pages from enhancements repo #11my-vm.yamlexample to include the requiredresourcefield in eachuser_valuesentryresourcesandresourcefields for users following the tutorialsDependent PR
control-planedependency so the CLI can serialize the new schema correctly (dcm-project/clibranchFLPATH-4770-fix-user-journey)Test plan
hugo --minifybuilds without errorshugo serverrenders both pages correctlyspec.resourcesrequired,user_values[].resourcerequired)Summary by Sourcery
Align the Getting Started VM tutorials with the current catalog item and instance schemas.
Bug Fixes:
Enhancements:
Documentation: