fix: supervise shutdown stops services only - #7
Merged
Conversation
Skip late-unmount and reboot/poweroff/halt in supervise mode so an embedded Host.Shutdown cannot umount /data on a live hub. Init mode is unchanged. Co-authored-by: Cursor <[email protected]>
keskad
force-pushed
the
fix/supervise-skip-unmount
branch
from
August 5, 2026 08:11
9f712be to
3ab10bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
microinit superviseshutdown now only stops services, syncs, and exits — no late-unmount script and noreboot(2)/ poweroff / halt.initmode is unchanged (unmount + machine shutdown).InitOpts.machine_shutdown+supervise_opts()gate the behavior.Test plan
cargo test --locked --test init_opts_testcargo test --locked --no-default-features --test init_opts_testcargo check --locked --no-default-featuresmicroinit supervise, confirm/datastays mounted after IPC shutdown / GoHost.Shutdown()Made with Cursor