Generate JSON schema from pydantic - #90
Merged
Merged
Conversation
What was I thinking?
We need to rely on mypy for this, as pylance doesn't have the necessary information to correctly analyze pydantic Models.
The generated schema is not yet on par with the handwritten one, but doing it in this order allows me to compare the output as I work.
This means the schema always matches the pydantic model. This has nice advantages for staying in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to generate the schema from the pydantic model, which means the model and the schema stay in sync. the result is that there's always a valid schema, and updates are effectively free.
Fixes: #72
Fixes: #88