Repository navigation
chore(deps): move to vite-plus 1.0 and unblock oxlint 1.85 and Vitest 5 (MMR-409) - #351
Conversation
…-409) Bump vite-plus to ^1.0.0, pin oxlint to its bundled 1.85.0, and pin the console's vitest to vite-plus's bundled 5.0.1. - Turn off oxlint 1.85's new style rule one-var locally; the shared @dbtlr/tooling change is filed as TLG-s1. - Shim jest-dom's Vitest 5 matcher types (testing-library/jest-dom#738) with the upstream fix from #742, so .resolves matchers stay awaitable. - Fix the new React lint errors: CSS @starting-style replaces the mount-time setState entry animation in the quick view, useEffectEvent replaces ref writes during render, and the search boxes re-sync from the URL during render instead of in an effect. - Hoist the functions consistent-function-scoping flags.
…-409) Review of the vite-plus 1.0 change found that a fresh onClose closure from a board poll re-ran the panel's Esc effect, whose cleanup cleared the pending close timer. Without the old mount-time setOpen(true), the panel then stuck invisible. Clear the timer only on unmount. Also let the panel's slide animate: Tailwind 4 translates through the translate property, which transition-[transform,opacity] never covered.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (23)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 SummarySummary by CodeRabbit
WalkthroughThe pull request updates tool versions and lint configuration, adjusts UI callbacks and search synchronization, and moves helpers to module scope. It changes quick-view entry and exit animations and adds a regression test for closing across a parent rerender. ChangesUI and tooling changes
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Merge Risk: ⚪ Minimal · up to The shelf can complete its close animation after a parent rerender. No confirmed issue prevents merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 20 files. (3 skipped: 3 unsupported.)
Comment |
|
@coderabbitai full review |
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Description
Upgrades the build and test toolchain to vite-plus 1.0, which unblocks oxlint 1.85 (linting), oxfmt 0.70 (formatting), and Vitest 5 (console test runner) — MMR-409.
Toolchain migration
onChangeRef,handlerRef,setFilterRef) are replaced with React'suseEffectEvent, and external query-string re-syncs for the search boxes (filters.qin artifact filters,search.qon the tasks page) now adjust state during render instead of in an effect. Small hoists in the PWA update controller, overview route, and tree test satisfy the new rules without behavior change.one-varstyle rule: oxlint 1.85 moved it into thestylecategory with ~6,237 existing hits; it is turned off as a deliberate opt-out until the shared tooling config relaxes it.Assertion<T>augmentation no longer merges with Vitest'sAssertion<R, T>testing-library/jest-dom#738): jest-dom 7.0.1's type augmentation doesn't merge with Vitest 5'sAssertion<R, T>, so matchers are now registered viaexpect.extendwith a corrected local module augmentation, to be removed once the upstream fix (jest-dom#742) ships.Behavior fixes surfaced by the migration
transformwhile the classes animatetranslate, so the slide was never transitioned. Entry animation now uses CSS@starting-style, making close the only state change; the mobile quick shelf gets the same treatment.onCloseclosure each render, a background refresh during the 180ms exit slide could cancel the pending close and strand the panel. Cleanup now runs only on unmount, with a regression test covering a parent re-render during the exit animation.