Better handle empty headers in vertical table#114
Merged
Conversation
If the headers parameter was an empty list, the header_len calculation in vertical_table() would raise. In addition, a later zip() would have dropped elements. To fix this, synthesize header elements of only spaces, based on the first row of data, when data is also nonempty. Just in case headers and data are both empty, provide a fallback so that the header_len calculation does not raise, but computes a zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the
headersparameter was an empty list, theheader_lencalculation invertical_table()would raise.In addition, a later
zip()would have dropped elements.To fix this, synthesize header elements of only spaces, based on the first row of
data, whendatais also nonempty.Just in case
headersanddataare both empty, provide a fallback so that theheader_lencalculation does not raise, but computes a zero.Checklist
CHANGELOG.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install), and ranblackon my code.