Skip to content

chore(deps-dev): bump the dev-dependencies group and implement ExecutionContext.abort - #572

Merged
davidwkeith merged 3 commits into
mainfrom
claude/loving-bell-kcfzk9
Oct 27, 2026
Merged

davidwkeith merged 3 commits into
mainfrom
claude/loving-bell-kcfzk9

Conversation

@davidwkeith

Copy link
Copy Markdown
Owner

Summary

Supersedes #565 (Dependabot dev-dependencies group: @cloudflare/workers-types 5.20261021.1, wrangler 4.151.3, @cloudflare/vitest-pool-workers 0.23.0, @fedify/* 2.4.4, eslint, prettier, typescript-eslint, @types/node).

That PR went red because the new @cloudflare/workers-types adds a required abort(reason?) to ExecutionContext, which @dwk/server's HostExecutionContext didn't implement. This merges Dependabot's branch and adds abort() to packages/server/src/context.ts, throwing on the Node host like the existing tracing / exports members.

Packages affected

@dwk/server (plus devDependency bumps across the workspace)

Checklist

  • Read the relevant spec(s) under spec/packages/ and updated them if
    behaviour changed — not applicable, type-compat shim only
  • Added/updated colocated tests (src/*.test.ts) — not applicable, enforced by typecheck
  • Ran the local CI gate: pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test
  • Added a changeset (pnpm changeset) if this touches a publishable
    package — not applicable, @dwk/server is private
  • Updated catalog.json / conformance/status.json if this adds a new
    mountable worker or changes conformance status — not applicable, no new worker

Generated by Claude Code

dependabot Bot and others added 3 commits October 24, 2026 23:55
Bumps the dev-dependencies group with 9 updates:

| Package | From | To |
| --- | --- | --- |
| [@cloudflare/vitest-pool-workers](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/vitest-pool-workers) | `0.20.2` | `0.23.0` |
| [@cloudflare/workers-types](https://github.com/cloudflare/workerd) | `5.20260804.1` | `5.20261021.1` |
| [@fedify/fedify](https://github.com/fedify-dev/fedify/tree/HEAD/packages/fedify) | `2.3.8` | `2.4.4` |
| [@fedify/vocab](https://github.com/fedify-dev/fedify/tree/HEAD/packages/vocab) | `2.3.8` | `2.4.4` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `26.6.3` | `26.6.5` |
| [eslint](https://github.com/eslint/eslint) | `10.11.0` | `10.13.0` |
| [prettier](https://github.com/prettier/prettier) | `3.9.9` | `3.9.10` |
| [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.70.1` | `8.72.0` |
| [wrangler](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler) | `4.119.0` | `4.151.3` |


Updates `@cloudflare/vitest-pool-workers` from 0.20.2 to 0.23.0
- [Release notes](https://github.com/cloudflare/workers-sdk/releases)
- [Commits](https://github.com/cloudflare/workers-sdk/commits/@cloudflare/[email protected]/packages/vitest-pool-workers)

Updates `@cloudflare/workers-types` from 5.20260804.1 to 5.20261021.1
- [Release notes](https://github.com/cloudflare/workerd/releases)
- [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md)
- [Commits](https://github.com/cloudflare/workerd/commits)

Updates `@fedify/fedify` from 2.3.8 to 2.4.4
- [Release notes](https://github.com/fedify-dev/fedify/releases)
- [Changelog](https://github.com/fedify-dev/fedify/blob/main/CHANGES.md)
- [Commits](https://github.com/fedify-dev/fedify/commits/2.4.4/packages/fedify)

Updates `@fedify/vocab` from 2.3.8 to 2.4.4
- [Release notes](https://github.com/fedify-dev/fedify/releases)
- [Changelog](https://github.com/fedify-dev/fedify/blob/main/CHANGES.md)
- [Commits](https://github.com/fedify-dev/fedify/commits/2.4.4/packages/vocab)

Updates `@types/node` from 26.6.3 to 26.6.5
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `eslint` from 10.11.0 to 10.13.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v10.11.0...v10.13.0)

Updates `prettier` from 3.9.9 to 3.9.10
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.9.9...3.9.10)

Updates `typescript-eslint` from 8.70.1 to 8.72.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.72.0/packages/typescript-eslint)

Updates `wrangler` from 4.119.0 to 4.151.3
- [Release notes](https://github.com/cloudflare/workers-sdk/releases)
- [Commits](https://github.com/cloudflare/workers-sdk/commits/[email protected]/packages/wrangler)

---
updated-dependencies:
- dependency-name: "@cloudflare/vitest-pool-workers"
  dependency-version: 0.23.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: "@cloudflare/workers-types"
  dependency-version: 5.20261021.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: "@fedify/fedify"
  dependency-version: 2.4.4
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: "@fedify/vocab"
  dependency-version: 2.4.4
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: "@types/node"
  dependency-version: 26.6.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: eslint
  dependency-version: 10.13.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: prettier
  dependency-version: 3.9.10
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: typescript-eslint
  dependency-version: 8.72.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: wrangler
  dependency-version: 4.151.3
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
…ndencies-73c0f3994e' into claude/loving-bell-kcfzk9
…61021

Brings in Dependabot's dev-dependencies group bump (#565), whose new
@cloudflare/workers-types adds a required abort() to ExecutionContext.
HostExecutionContext now implements it, throwing like tracing/exports.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015LRGjhYv6NRtNKVd7kWr4e

Copy link
Copy Markdown
Owner Author

Review

The code change is small and correct. HostExecutionContext.abort() in packages/server/src/context.ts throws like the existing tracing and exports members, and its doc comment matches the surrounding style. No other ExecutionContext implementers turned up in packages/*/src, so I don't see a missing implementation elsewhere. The remaining diff is devDependency bumps and the lockfile, and the pinned exact versions match the repo convention.

Needs fixing (CONTRIBUTING.md conformance)

  1. PR title. Squash-merge makes the title the permanent git log entry, and the scope should be the package name. chore(deps-dev) is Dependabot's scope, not a package. The PR also mixes a dependency bump with a fix(server) change. Suggested: fix(server): implement ExecutionContext.abort and bump dev-dependencies, or chore(server,...): ... if you prefer to keep the chore type.
  2. Checklist wording. The unchecked items each have a one-line reason, which is what CONTRIBUTING.md asks for. "Added/updated colocated tests — not applicable, enforced by typecheck" is thin, though. Since abort() deliberately throws, a one-line test in packages/server/src/context.test.ts asserting the throw would be cheap and would pin the behaviour. Add it, or keep the justification as is.
  3. Local CI gate box is checked, but CI is still running. build-test, integration, release-gate, image and CodeQL were all pending when I reviewed. Please confirm all of lint, format:check, typecheck, build and test go green before merging. Dependabot's eslint, prettier and typescript-eslint bumps can change lint and format output.

Notes (no action needed)


Generated by Claude Code

@davidwkeith
davidwkeith merged commit cc0aae6 into main Oct 27, 2026
9 checks passed
@davidwkeith
davidwkeith deleted the claude/loving-bell-kcfzk9 branch October 27, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants