Repository navigation
chore(deps): bump @dotenvx/dotenvx from 2.21.0 to 2.30.0 - #528
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [@dotenvx/dotenvx](https://github.com/dotenvx/dotenvx) from 2.21.0 to 2.30.0. - [Release notes](https://github.com/dotenvx/dotenvx/releases) - [Changelog](https://github.com/dotenvx/dotenvx/blob/main/CHANGELOG.md) - [Commits](dotenvx/dotenvx@v2.21.0...v2.30.0) --- updated-dependencies: - dependency-name: "@dotenvx/dotenvx" dependency-version: 2.30.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
davidwkeith
left a comment
There was a problem hiding this comment.
Reviewed this Dependabot bump (@dotenvx/dotenvx 2.21.0 → 2.30.0 in packages/server, a private/unpublished package). A few notes against CONTRIBUTING.md:
Conventional Commits / squash-merge title (CONTRIBUTING.md §6)
The PR title chore(deps): bump @dotenvx/dotenvx from 2.21.0 to 2.30.0 uses deps as the scope. This repo's convention is scope = package name minus the @dwk/ prefix (fix(solid-pod): …), and since this repo squash-merges, the PR title is what lands permanently in git log. Only @dwk/server is touched here, so per the letter of the rule this should be retitled to something like chore(server): bump @dotenvx/dotenvx from 2.21.0 to 2.30.0 before merging. Since Dependabot generates this text automatically, consider adding a commit-message block to .github/dependabot.yml to template the scope, or just edit the title manually pre-merge.
PR body / template (CONTRIBUTING.md §7)
The body is Dependabot's default changelog dump rather than .github/PULL_REQUEST_TEMPLATE.md's Summary / Packages affected / Checklist sections. Not something Dependabot fills in on its own — flagging per the letter of the contributing guide, but this is presumably an accepted exception for bot PRs rather than something to fix here.
Changeset (CONTRIBUTING.md §5) — correctly omitted. @dwk/server is "private": true and never published, so no changeset is needed for this bump.
Dependency footprint worth a second look
@dotenvx/dotenvx 2.28.0–2.30.0 added the "Armor" managed-key-custody / dotenvx protect / CLI audit-logging features, and the lockfile diff shows several new transitive deps as a result: global-agent, node-forge, roarr, matcher, serialize-error, etc. [email protected] (pulled in via global-agent → roarr) is flagged deprecated by npm ("Package no longer supported").
packages/server/src/env.tsonly calls dotenvx's programmaticconfig()/parse(), not the CLI subcommands, so these new code paths are likely dead weight rather than something that executes — but worth confirming none of the new audit-logging/telemetry behavior fires duringconfig()/parse(), given this project's self-hosted-only, no-phone-home design stance.global-agentglobally patches the process's HTTP(S) agent based on env vars (GLOBAL_AGENT_HTTP_PROXY, etc.) when invoked — worth a quick check that nothing in dotenvx'sconfig()path triggers that at import/call time in a way that could affect other outbound requests in the same process.
Test coupling to dotenvx internals
packages/server/src/env.test.ts resolves @dotenvx/dotenvx's CLI entry directly via require.resolve("@dotenvx/dotenvx/package.json") + src/cli/dotenvx.js. The 2.28.1 changelog notes "move some commands under a hidden menu," so it'd be good to confirm the build-test CI job (still running as of this review) actually passes — that path is exactly what would break silently if dotenvx restructured its CLI layout.
Nothing here blocks a patch/minor dependency bump outright, but the title should be fixed to match the repo's commit convention before this squash-merges, and it'd be worth a human sanity-check on the audit-logging/telemetry behavior given the project's self-hosting stance.
Generated by Claude Code
|
Superseded by #532. |
Bumps @dotenvx/dotenvx from 2.21.0 to 2.30.0.
Release notes
Sourced from @dotenvx/dotenvx's releases.
Changelog
Sourced from @dotenvx/dotenvx's changelog.
... (truncated)
Commits
6055cb52.30.0c191adachangelog055506bMerge pull request #985 from dotenvx/update-sealed8b418a0support secrets references as safe to commit7ba3b36Merge pull request #983 from dotenvx/events99cc435test updates5845a4apreserve large piped outputda827f0handle embedded cli74e269elimit worker environment5d20647rewrite actions to returnDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)