Repository navigation
chore: bump dev-dependencies group, hold back workers-types/wrangler - #526
Conversation
davidwkeith
left a comment
There was a problem hiding this comment.
Automated review
CI is red, and it's not a flake. build-test, integration, and image all fail with the same root cause:
packages/cf-shims/src/durable-object.ts(497,61): error TS2554: Expected 0 arguments, but got 1.
That's randomBytes(32).toString("hex") inside DurableObjectNamespace.newUniqueId(). It typechecks fine on main (@types/[email protected]), but breaks under this PR's bump to @types/[email protected] — Buffer#toString appears to resolve to a 0-arg overload after the update. pnpm --filter @dwk/cf-shims typecheck reproduces it locally. This needs a source-level fix (or holding back @types/node in this group) before merge — per spec/conformance-and-testing.md / the CI gate, lint → format → typecheck → build → test must all pass, and right now typecheck doesn't.
PR title, minor: chore(deps-dev): bump the dev-dependencies group across 1 directory with 11 updates uses deps-dev as scope. CONTRIBUTING.md's Conventional Commits section says scope is a package name, or omitted entirely for a repo-wide change (chore: …) — this repo squash-merges, so the PR title becomes the permanent commit message. History is mixed here (#493/#486 kept deps-dev as-is, #507 was retitled to drop the scope before merge), so this is a judgment call for whoever merges, not a hard blocker.
Changeset: correctly omitted. This only touches devDependencies workspace-wide, not a publishable package's runtime surface, so no changeset is required.
Version consistency: the bumped versions line up across the root package.json and packages/cf-shims, packages/conformance-target, packages/deno-host, packages/server, and pnpm-lock.yaml — no mismatched pins.
Recommendation: hold this PR until the @dwk/cf-shims typecheck failure is fixed; everything else here is clean, routine dependency-bump content.
Generated by Claude Code
980e0fb to
bd3f4ef
Compare
…wrangler @cloudflare/workers-types still ships the global `declare const Buffer: any` (nodejs_compat ambient global) through 5.20260928.1, verified with a minimal repro and by bisecting the group's updates individually. Merged into a package's `types` array alongside @types/node (cf-shims, server, conformance-target), it breaks resolution of Node's own Buffer overloads: any `buf.toString(encoding)` call resolves to the zero-arg `Object.prototype.toString` instead, which previously broke cf-shims's typecheck and would also drop ExecutionContext's new `abort` member on @dwk/server. Same root cause as #507. wrangler peer-depends on a matching workers-types range, and vitest-pool-workers pulls in that wrangler, so all three are held back together. eslint, prettier, typescript-eslint, @types/node, @changesets/cli, @libsql/client, and @fedify/fedify+vocab keep their bumps. Rebased onto main after #519 and #533 merged ahead of this PR. Frozen install, lint, format, typecheck, build, and the full test suite all pass. Co-Authored-By: Claude Sonnet 5 <[email protected]>
0e74f0d to
291cf11
Compare
Bumps ws to 8.22.0 and @types/ws to 8.18.2 in packages/server. Rebased onto main after #519, #522, #526, #532, and #533 merged ahead of this PR; no content changes beyond the ws bump itself. Signed-off-by: dependabot[bot] <[email protected]> Co-Authored-By: Claude Sonnet 5 <[email protected]>
Bumps ws to 8.22.0 and @types/ws to 8.18.2 in packages/server. Rebased onto main after #519, #522, #526, #532, and #533 merged ahead of this PR; no content changes beyond the ws bump itself. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: David W. Keith <[email protected]> Co-authored-by: Claude Sonnet 5 <[email protected]>
Bumps the dev-dependencies group with 11 updates in the / directory:
3.0.03.0.30.20.20.22.05.20260804.15.20260928.12.3.42.3.82.3.42.3.826.2.026.6.310.8.110.11.03.9.63.9.98.67.08.70.14.119.04.142.00.17.40.18.0Updates
@changesets/clifrom 3.0.0 to 3.0.3Release notes
Sourced from @changesets/cli's releases.
Changelog
Sourced from @changesets/cli's changelog.
Commits
c9269c0Version Packages (#2291)ca9d110Fix pnpm 10 publishing with npm 12 (#2276)7be7fdeBuild(deps): Bump the production-dependencies group across 1 directory with 6...b430ce0Move e2e tests to an on-demand workspace (#2275)93314a8test: add happy path tests foradd(#2289)d13a39etest: use inline snapshots for publish plan tests (#2284)d7e4a2dVersion Packages (#2266)68affeeUpgrade to Vitest 5 (#2281)5eeb012Build(deps): Bump human-id in the production-dependencies group (#2279)a0a4dc6Add review message on pre exit (#2270)Updates
@cloudflare/vitest-pool-workersfrom 0.20.2 to 0.22.0Release notes
Sourced from @cloudflare/vitest-pool-workers's releases.
... (truncated)
Changelog
Sourced from @cloudflare/vitest-pool-workers's changelog.
... (truncated)
Commits
8ee43f6Version Packages (#15175)3ddd3ceFix module resolution for relativerequire()inside CJS deps when the proje...1f79aceUse a fixed default compatibility date derived from the pinned workerd (#15185)2cf3143[vitest-pool-workers] Restore typed inject() keys (#15150)49d4e00[vitest-pool-workers] Adopt@msw/cloudflareand remove MSW workarounds (#13830)c576a82Version Packages (#15154)e5d56e9Version Packages (#15145)d0c976cBump the workerd-and-workers-types group across 1 directory with 2 updates (#...90dd5e5chore: bump capnp-es to 0.0.15 (#15131)15fc568Version Packages (#15118)Updates
@cloudflare/workers-typesfrom 5.20260804.1 to 5.20260928.1Commits
Updates
@fedify/fedifyfrom 2.3.4 to 2.3.8Release notes
Sourced from @fedify/fedify's releases.
... (truncated)
Changelog
Sourced from @fedify/fedify's changelog.
... (truncated)
Commits
d52c887Merge tag '2.2.13' into 2.3-maintenancec865e13Merge tag '2.1.24' into 2.2-maintenance5e58258Merge tag '2.0.28' into 2.1-maintenanceb230a91Stop trusting a key's own word about its ownera2847feBound federation bodies before parsing JSON68ec7b4Validate outbound activity delivery destinationsa9eb37cVersion bump062935eVersion bump72b4cd7Version bumpd863a12Version bumpUpdates
@fedify/vocabfrom 2.3.4 to 2.3.8Release notes
Sourced from @fedify/vocab's releases.
... (truncated)
Changelog
Sourced from @fedify/vocab's changelog.
... (truncated)
Commits
39bc84cUse a public IP literal in the actor handle discovery testsd52c887Merge tag '2.2.13' into 2.3-maintenancec865e13Merge tag '2.1.24' into 2.2-maintenance5e58258Merge tag '2.0.28' into 2.1-maintenancecd3a6ccRun fixture tests in Node ESM buildsa9eb37cVersion bump062935eVersion bump72b4cd7Version bumpd863a12Version bump8a6c076Version bumpUpdates
@types/nodefrom 26.2.0 to 26.6.3Commits
Updates
eslintfrom 10.8.1 to 10.11.0Release notes
Sourced from eslint's releases.
... (truncated)
Commits
...Description has been truncated