Repository navigation
ci: build the CLI in the Standards workflow instead of its own - #57
Merged
Merged
Conversation
Owner
Author
Review and fix
Final gate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before. The project-owned
nix.ymlbuilt the CLI a second time on every pull request and push, required by the "Require the Nix build" ruleset, now that the synced Standards workflow builds every package the flake exposes inside the requiredcheck(davidvornholt/standards#568). Its only extra coverage was runningsp --helpand comparing the installed skills withapps/cli/skills. Closes #56.Now. The CLI is built once per run, in
check. The binary and skills checks moved into the package as aninstallCheckPhase, so they fail that same build, andnix.ymland its ruleset are gone.Implementation
nix/package.nix:doInstallCheck, which runssp --helpanddiff -r ${../apps/cli/skills} "$out/share/sp-cli/skills". It compares with the unfiltered skills directory, asnix.ymlcompared with the checkout, so a tracked skill file that a.gitignoreline keeps out of the package source still fails. Unlikenix.yml's per-skill loop, it also fails on an extra file or directory in the installed skills..github/workflows/nix.yml;.github/settings.local.jsondeclares no extra ruleset. The live "Require the Nix build" ruleset is already deleted withstandards github --apply;standards github --checkreports no drift, andmainstill requirescheck.b2ba699. Besides the package build, it brings thedraft-statejob (a short job on draft runs that gates a head marked ready while its draft run starts), the brokered-token docs from standards#545/#566, and one Biome override path that only matters in the standards repository. This is the same sync ci: build the CLI in the Standards workflow instead of its own rota#174 took.Verification
Completed checks
bun run checkpassed on this commit, and its Turbo tasks passed again with--force(8/8 tasks, no cache).checks.x86_64-linux.package-source,defaultandsp-cli, with the install check passing.Only in …/share/sp-cli/skills: stray.Opened by Claude Opus 5.5 in Claude Code via T3 Code.