Skip to content

ci: build the CLI in the Standards workflow instead of its own - #57

Merged
davidvornholt merged 2 commits into
mainfrom
nightshift/build-once
Nov 16, 2026
Merged

davidvornholt merged 2 commits into
mainfrom
nightshift/build-once

Conversation

@davidvornholt

Copy link
Copy Markdown
Owner

Before. The project-owned nix.yml built the CLI a second time on every pull request and push, required by the "Require the Nix build" ruleset, now that the synced Standards workflow builds every package the flake exposes inside the required check (davidvornholt/standards#568). Its only extra coverage was running sp --help and comparing the installed skills with apps/cli/skills. Closes #56.

Now. The CLI is built once per run, in check. The binary and skills checks moved into the package as an installCheckPhase, so they fail that same build, and nix.yml and its ruleset are gone.

Implementation

  • nix/package.nix: doInstallCheck, which runs sp --help and diff -r ${../apps/cli/skills} "$out/share/sp-cli/skills". It compares with the unfiltered skills directory, as nix.yml compared with the checkout, so a tracked skill file that a .gitignore line keeps out of the package source still fails. Unlike nix.yml's per-skill loop, it also fails on an extra file or directory in the installed skills.
  • Deleted .github/workflows/nix.yml; .github/settings.local.json declares no extra ruleset. The live "Require the Nix build" ruleset is already deleted with standards github --apply; standards github --check reports no drift, and main still requires check.
  • Sync to standards b2ba699. Besides the package build, it brings the draft-state job (a short job on draft runs that gates a head marked ready while its draft run starts), the brokered-token docs from standards#545/#566, and one Biome override path that only matters in the standards repository. This is the same sync ci: build the CLI in the Standards workflow instead of its own rota#174 took.

Verification

Completed checks

  • bun run check passed on this commit, and its Turbo tasks passed again with --force (8/8 tasks, no cache).
  • The canonical Standards step, run locally on this commit, built checks.x86_64-linux.package-source, default and sp-cli, with the install check passing.
  • With a stray file added to the installed skills, the build failed with Only in …/share/sp-cli/skills: stray.

Opened by Claude Opus 5.5 in Claude Code via T3 Code.

@davidvornholt

Copy link
Copy Markdown
Owner Author

Review and fix

Review Reviewers Findings Outcome
670cb5d against main Behavior, premise (GPT-6 Astra, high) none No changes
Fix review none none Skipped: no fixes

Final gate: bun run check passed on 670cb5d (8/8 Turbo tasks, also with --force), and the canonical Standards package step built package-source, default and sp-cli with the install check. Total time: about 5 minutes.

@davidvornholt
davidvornholt marked this pull request as ready for review November 16, 2026 18:44
@davidvornholt
davidvornholt merged commit ef4f1c1 into main Nov 16, 2026
19 checks passed
@davidvornholt
davidvornholt deleted the nightshift/build-once branch November 16, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build the CLI once, in the Standards workflow

1 participant